Cleaned up skip* functions from framework/util.go #83219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an effort to clean up the framework util.go file so that it makes more sense and it is more managable. Signed-off-by: alejandrox1 <alarcj137@gmail.com>
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
area/e2e-test-framework
|
/assign @oomichi @andrewsykim @timothysc |
|
This seems very clean separation for me, thanks. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alejandrox1, timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: alejandrox1 alarcj137@gmail.com
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This is an effort to clean up the framework util.go file so that it
makes more sense and it is more managable.
Which issue(s) this PR fixes:
tangentially related to #77095
Does this PR introduce a user-facing change?:
/area e2e-test-framework
/sig testing
/priority backlog
/milestone v1.17