New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deflake TestWatchBasedManager #83250
Deflake TestWatchBasedManager #83250
Conversation
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lavalamp, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/priority important-soon |
@liggitt: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Thanks Jordan. lgtm |
…0-upstream-release-1.16 Automated cherry pick of #83250: Deflake TestWatchBasedManager
…0-upstream-release-1.15 Automated cherry pick of #83250: Deflake TestWatchBasedManager
What type of PR is this?
/kind flake
/area deflake
What this PR does / why we need it:
Follow up to #80465
The TestWatchBasedManager integration test was using the loopback server client config as a starting point, and increasing QPS. Now that the loopback does not set QPS or Burst, the integration test needs to override both.
Does this PR introduce a user-facing change?:
/cc @lavalamp
/sig api-machinery