Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deflake TestWatchBasedManager #83250

Merged
merged 1 commit into from Sep 27, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Sep 27, 2019

What type of PR is this?
/kind flake
/area deflake

What this PR does / why we need it:
Follow up to #80465

The TestWatchBasedManager integration test was using the loopback server client config as a starting point, and increasing QPS. Now that the loopback does not set QPS or Burst, the integration test needs to override both.

Does this PR introduce a user-facing change?:

NONE

/cc @lavalamp
/sig api-machinery

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/deflake Issues or PRs related to deflaking kubernetes tests sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 27, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 27, 2019
@lavalamp
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member Author

liggitt commented Sep 27, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 27, 2019
@k8s-ci-robot
Copy link
Contributor

@liggitt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-conformance-kind-ipv6 c7932e1 link /test pull-kubernetes-conformance-kind-ipv6

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit a5135ec into kubernetes:master Sep 27, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 27, 2019
k8s-ci-robot added a commit that referenced this pull request Sep 27, 2019
…5-upstream-release-1.14

Automated cherry pick of #80465 #83250: remove apiserver loopback client QPS limit
@wojtek-t
Copy link
Member

Thanks Jordan.

lgtm

k8s-ci-robot added a commit that referenced this pull request Sep 29, 2019
…0-upstream-release-1.16

Automated cherry pick of #83250: Deflake TestWatchBasedManager
k8s-ci-robot added a commit that referenced this pull request Sep 30, 2019
…0-upstream-release-1.15

Automated cherry pick of #83250: Deflake TestWatchBasedManager
@liggitt liggitt deleted the deflake-watch-based-manager branch October 3, 2019 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/deflake Issues or PRs related to deflaking kubernetes tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants