Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix golint errors for pkg/master #83297

Merged
merged 1 commit into from
Oct 5, 2019

Conversation

m3ngyang
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
fix a wrong comment

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 30, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @m3ngyang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 30, 2019
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 30, 2019
@roycaihw
Copy link
Member

/cc @cheftako

@cheftako
Copy link
Member

Thanks for helping with our quality.
I assume for looking at the changes you are trying to get our lint errors down.
If we don't clear all the errors in the directory and then mark the directory as clean then it is very easy for someone else to (re)introduce more lint errors in the directory.
Can you remove pkg/master from https://github.com/kubernetes/kubernetes/blob/master/hack/.golint_failures#L140?

@m3ngyang
Copy link
Contributor Author

m3ngyang commented Oct 1, 2019

Do I need to fix all golint errors in pkg/master before removing it from golint_failures. There exists some other golint errors, such as exported functions/structs lacking comments. @cheftako

@jpbetz
Copy link
Contributor

jpbetz commented Oct 1, 2019

/ok-to-test
/lgtm
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 1, 2019
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 1, 2019
@cheftako
Copy link
Member

cheftako commented Oct 1, 2019

@m3ngyang Yes you would need to fix the remaining golint errors for pkg/master. However I think that is the right way to proceed.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 3, 2019
@m3ngyang m3ngyang changed the title fix a wrong comment fix golint errors for pkg/master Oct 3, 2019
pkg/master/controller.go Outdated Show resolved Hide resolved
@m3ngyang m3ngyang force-pushed the controller-comment branch 2 times, most recently from 2ac2a7b to 9cada5b Compare October 4, 2019 02:18
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Oct 4, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Oct 4, 2019
@m3ngyang
Copy link
Contributor Author

m3ngyang commented Oct 4, 2019

/test pull-kubernetes-e2e-gce-100-performance
/test pull-kubernetes-kubemark-e2e-gce-big

@m3ngyang
Copy link
Contributor Author

m3ngyang commented Oct 4, 2019

/retest

@m3ngyang
Copy link
Contributor Author

m3ngyang commented Oct 4, 2019

@cheftako all tests have completed.

@cheftako
Copy link
Member

cheftako commented Oct 4, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2019
@cheftako
Copy link
Member

cheftako commented Oct 4, 2019

Hi @m3ngyang, you need to assign one of the "OWNERS" from the links above to get merge approval.

@m3ngyang
Copy link
Contributor Author

m3ngyang commented Oct 5, 2019

/assign @liggitt
/assign @deads2k
PTAL~

pkg/master/master.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2019
@m3ngyang
Copy link
Contributor Author

m3ngyang commented Oct 5, 2019

/retest

@liggitt
Copy link
Member

liggitt commented Oct 5, 2019

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, m3ngyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 469d6db into kubernetes:master Oct 5, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 5, 2019
@m3ngyang m3ngyang deleted the controller-comment branch October 6, 2019 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants