-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix golint errors for pkg/master #83297
Conversation
Hi @m3ngyang. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @cheftako |
Thanks for helping with our quality. |
f093098
to
3a71f29
Compare
Do I need to fix all golint errors in |
/ok-to-test |
@m3ngyang Yes you would need to fix the remaining golint errors for pkg/master. However I think that is the right way to proceed. |
3a71f29
to
9c587e7
Compare
2ac2a7b
to
9cada5b
Compare
9cada5b
to
448e24b
Compare
/test pull-kubernetes-e2e-gce-100-performance |
/retest |
@cheftako all tests have completed. |
/lgtm |
Hi @m3ngyang, you need to assign one of the "OWNERS" from the links above to get merge approval. |
448e24b
to
ed8767c
Compare
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, m3ngyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
fix a wrong comment
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: