-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: make getVolumeLimits a function instead of a method #83310
scheduler: make getVolumeLimits a function instead of a method #83310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @bsalamat |
/assign @Huang-Wei |
/assign @thockin Thanks :) |
/uncc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Huang-Wei, SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
At first, I was confused.
I think the
csiNode
in the argument list ofgetVolumeLimits
was redundant,Because we can get the
csiNode
by some code like this:But when I got down to it, I realized that this function is only called by
attachableLimitPredicate
.In
attachableLimitPredicate
function, we already computed thecsiNode
.So it is efficient to use it directly, and there is no need to repeat the calculation.
Based on the above analysis, I think
getVolumeLimits
should be a normal function rather than a method.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: