Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: make getVolumeLimits a function instead of a method #83310

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Sep 30, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
At first, I was confused.
I think the csiNode in the argument list of getVolumeLimits was redundant,
Because we can get the csiNode by some code like this:

csiNode, err := c.csiNodeInfo.GetCSINodeInfo(node.Name)

But when I got down to it, I realized that this function is only called by attachableLimitPredicate.
In attachableLimitPredicate function, we already computed the csiNode.
So it is efficient to use it directly, and there is no need to repeat the calculation.
Based on the above analysis, I think getVolumeLimits should be a normal function rather than a method.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 30, 2019
Copy link
Contributor

@wgliang wgliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2019
@SataQiu
Copy link
Member Author

SataQiu commented Oct 1, 2019

/assign @bsalamat

@SataQiu
Copy link
Member Author

SataQiu commented Oct 4, 2019

/assign @Huang-Wei

@SataQiu
Copy link
Member Author

SataQiu commented Oct 10, 2019

/assign @thockin Thanks :)

@draveness
Copy link
Contributor

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from draveness October 10, 2019 07:20
Copy link
Member

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8138e8d into kubernetes:master Oct 21, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants