Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: add 1.18 entry in the etcd map #83314

Merged
merged 2 commits into from
Oct 4, 2019
Merged

kubeadm: add 1.18 entry in the etcd map #83314

merged 2 commits into from
Oct 4, 2019

Conversation

fabriziopandini
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Add 1.18 entry in the etcd map

Which issue(s) this PR fixes:
xref #kubernetes/kubeadm#1807

Does this PR introduce a user-facing change?:

NONE

/assign @neolit123
/priority important-soon
/area kubeadm

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 30, 2019
@fabriziopandini
Copy link
Member Author

/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 30, 2019
@fabriziopandini fabriziopandini mentioned this pull request Sep 30, 2019
Closed
7 tasks
ereslibre
ereslibre approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fabriziopandini!

/lgtm
/approve
/hold

Feel free to unhold.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ereslibre, fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ereslibre
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2019
@fabriziopandini
Copy link
Member Author

@neolit123 removed the entry for 1.12 as well

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 2, 2019
@fabriziopandini
Copy link
Member Author

@neolit123 @ereslibre
make tests pass and refactor upgrade test so they will automatically stay up to grade with new releases

@neolit123
Copy link
Member

/lgtm

make tests pass and refactor upgrade test so they will automatically stay up to grade with new releases

awesome
xref kubernetes/kubeadm#1260

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2019
rosti
rosti reviewed Oct 2, 2019
View reviewed changes
Copy link
Contributor

@rosti rosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fabriziopandini !
I like the refactoring, but can we split the commits in a couple of different PRs?

@fabriziopandini
Copy link
Member Author

fabriziopandini commented Oct 3, 2019 •
edited

@rosti
The etcd map change and test refactoring are already in separated commits.
Test refactoring is the biggest one, but TBH, being a refactor of a single func I find a little bit forceful to split it in separated PR...

@rosti
Copy link
Contributor

rosti commented Oct 4, 2019

Ok, let's merge it like this then. We did a few reviews of this already and it looks good.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7f6d7af into kubernetes:master Oct 4, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 4, 2019
@fabriziopandini fabriziopandini deleted the add-etcd-version branch October 10, 2019 07:12
@neolit123 neolit123 mentioned this pull request Dec 11, 2019
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@rosti rosti rosti left review comments

@ereslibre ereslibre ereslibre approved these changes

@kad kad Awaiting requested review from kad

Assignees

@ereslibre ereslibre

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fabriziopandini @k8s-ci-robot @ereslibre @neolit123 @rosti