Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check whether mirror pod is ciritical in managerImpl#evictPod #83325

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Check whether mirror pod is ciritical in managerImpl#evictPod #83325

merged 1 commit into from
Oct 8, 2019

Conversation

tedyu
Copy link
Contributor

@tedyu tedyu commented Sep 30, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
As #83317 reported, static pod would be evicted when diskPressure arises.

This PR adds check for mirror pod for criticality.

Which issue(s) this PR fixes:
Fixes #83317

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 30, 2019
@tedyu tedyu mentioned this pull request Sep 30, 2019
Closed
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 30, 2019
@yutedz yutedz force-pushed the static-mirror-pod branch 2 times, most recently from 8d44ec5 to aa11dfb Compare September 30, 2019 16:37
@hpandeycodeit
Copy link

/assign @bsalamat

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 30, 2019
@tedyu
Copy link
Contributor Author

tedyu commented Sep 30, 2019

@bsalamat
Please take another look.

@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 30, 2019
@yutedz yutedz force-pushed the static-mirror-pod branch 5 times, most recently from 1512db9 to 51c5a00 Compare October 1, 2019 03:13
hpandeycodeit
hpandeycodeit reviewed Oct 1, 2019
View reviewed changes
Copy link

@hpandeycodeit hpandeycodeit left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

bsalamat
bsalamat approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

pkg/kubelet/types/pod_update.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 1, 2019
@hpandeycodeit
Copy link

/lgtm

@tedyu
Copy link
Contributor Author

tedyu commented Oct 1, 2019

/test pull-kubernetes-e2e-gce

1 similar comment
@tedyu
Copy link
Contributor Author

tedyu commented Oct 1, 2019

/test pull-kubernetes-e2e-gce

bsalamat
bsalamat reviewed Oct 2, 2019
View reviewed changes
Copy link
Member

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2019
@tedyu
Copy link
Contributor Author

tedyu commented Oct 3, 2019

@dchen1107
Can you take a look ?

@KeepTheBeats
Copy link

/lgtm

@k8s-ci-robot
Copy link
Contributor

@KeepTheBeats: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dchen1107
Copy link
Member

Ok with the fix, but asked one question at: #83317 (comment)

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, dchen1107, tedyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2019
@tedyu
Copy link
Contributor Author

tedyu commented Oct 8, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit 72cd1c1 into kubernetes:master Oct 8, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 8, 2019
@andy-wolf168
Copy link

andy-wolf168 commented Jan 9, 2020 •
edited

@dchen1107 @tedyu can this PR merge to k8s 1.15?

@tpepper tpepper mentioned this pull request Apr 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsalamat bsalamat bsalamat approved these changes

@andy-wolf168 andy-wolf168 andy-wolf168 left review comments

@hpandeycodeit hpandeycodeit hpandeycodeit left review comments

@mtaufen mtaufen Awaiting requested review from mtaufen

@sjpotter sjpotter Awaiting requested review from sjpotter

Assignees

@dchen1107 dchen1107

@bsalamat bsalamat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

Static pods be evicted when diskPressure. Commit c05d506 doesn't seem to work.
8 participants
@tedyu @hpandeycodeit @KeepTheBeats @k8s-ci-robot @dchen1107 @andy-wolf168 @bsalamat @yutedz