Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sig-node test by adding back the numNodes #83376

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Fix sig-node test by adding back the numNodes #83376

merged 1 commit into from
Oct 3, 2019

Conversation

liyanhui1228
Copy link
Contributor

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Adding back an accidentally removed variable numNodes, which was causing sig-node test to fail.

Which issue(s) this PR fixes:

Fixes #83316

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 1, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @liyanhui1228. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 1, 2019
@liyanhui1228
Copy link
Contributor Author

/assign @yujuhong

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 1, 2019
@yujuhong
Copy link
Contributor

yujuhong commented Oct 1, 2019

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 1, 2019
@yujuhong yujuhong added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 1, 2019
@k8s-ci-robot k8s-ci-robot removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 1, 2019
@yujuhong
Copy link
Contributor

yujuhong commented Oct 1, 2019

/cc @danwinship @timothysc from #82291, which introduced the regression.

@liyanhui1228
Copy link
Contributor Author

/retest

1 similar comment
@liyanhui1228
Copy link
Contributor Author

/retest

@yujuhong
Copy link
Contributor

yujuhong commented Oct 1, 2019

pull-kubernetes-conformance-kind-ipv6 is not required. if it fails again, no need to retest

odinuge
odinuge approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@odinuge odinuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking this down and filing a fix this quickly!

/lgtm

Is there a reason you removed the /approve again @yujuhong? Would be nice to get this merged as soon as possible

@yujuhong
Copy link
Contributor

yujuhong commented Oct 2, 2019

/approve

removed it by accident

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liyanhui1228, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2019
@liyanhui1228
Copy link
Contributor Author

/retest

2 similar comments
@liyanhui1228
Copy link
Contributor Author

/retest

@liyanhui1228
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 8e39c60 into kubernetes:master Oct 3, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odinuge odinuge odinuge approved these changes

@yifan-gu yifan-gu Awaiting requested review from yifan-gu

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@odinuge odinuge

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
4 participants
@liyanhui1228 @k8s-ci-robot @yujuhong @odinuge