Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the return value from store.Update #83420

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Check the return value from store.Update #83420

merged 1 commit into from
Oct 4, 2019

Conversation

tedyu
Copy link
Contributor

@tedyu tedyu commented Oct 2, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Currently the error return from store.Update is ignored.

This PR adds check for the return value.

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 2, 2019
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 2, 2019
@msau42
Copy link
Member

msau42 commented Oct 3, 2019

/lgtm
/approve
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, tedyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2019
@tedyu
Copy link
Contributor Author

tedyu commented Oct 4, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@tedyu
Copy link
Contributor Author

tedyu commented Oct 4, 2019

/test pull-kubernetes-e2e-gce-100-performance

@tedyu
Copy link
Contributor Author

tedyu commented Oct 4, 2019

/test pull-kubernetes-e2e-gce

@tedyu
Copy link
Contributor Author

tedyu commented Oct 4, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

1 similar comment
@tedyu
Copy link
Contributor Author

tedyu commented Oct 4, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@tedyu
Copy link
Contributor Author

tedyu commented Oct 4, 2019

/test pull-kubernetes-e2e-gce-100-performance

@tedyu
Copy link
Contributor Author

tedyu commented Oct 4, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@tedyu
Copy link
Contributor Author

tedyu commented Oct 4, 2019

/test pull-kubernetes-e2e-gce-100-performance

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@tedyu
Copy link
Contributor Author

tedyu commented Oct 4, 2019

/test pull-kubernetes-e2e-gce-100-performance

1 similar comment
@tedyu
Copy link
Contributor Author

tedyu commented Oct 4, 2019

/test pull-kubernetes-e2e-gce-100-performance

@k8s-ci-robot k8s-ci-robot merged commit 74dc287 into kubernetes:master Oct 4, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 4, 2019
@k8s-ci-robot
Copy link
Contributor

@tedyu: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce c264338 link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lichuqiang lichuqiang Awaiting requested review from lichuqiang

@msau42 msau42 Awaiting requested review from msau42

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tedyu @msau42 @k8s-ci-robot @fejta-bot @yutedz