feat(scheduler): rename PluginContext to CycleState

[draveness]

/kind cleanup
/sig scheduling
/assign @alculquicondor @ahg-g

What this PR does / why we need it:
rename PluginContext to CycleState

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Rename PluginContext to CycleState in the scheduling framework

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[draveness]

/retest

[alculquicondor]

/lgtm

Any particular reason why you used the variable name cycleState in some places and state in others?
I'm ok with just having state for the variables unless there is ambiguity.

[draveness]

Any particular reason why you used the variable name cycleState in some places and state in others?
I'm ok with just having state for the variables unless there is ambiguity.

I make the following changes

• pluginContext -> cycleState
• pc -> state

[alculquicondor]

To increase consistency, I suggest we just use state unless there's a collision. WDYT @ahg-g ?

[draveness]

To increase consistency, I suggest we just use state unless there's a collision. WDYT @ahg-g ?

I think it would be hard to do this since we already have such inconsistency among the codebase, e.g. pluginContext and pc. If you think it would be a problem, I could replace cycleState with state in the PR. But it does not sound like a big problem to me.

[ahg-g]

To increase consistency, I suggest we just use state unless there's a collision. WDYT @ahg-g ?

+1 for consistency. We can't use cs since it refers usually to a ClientSet instance, so I guess we can set the precedence that state in the context of the scheduler means CycleState.

[draveness]

To increase consistency, I suggest we just use state unless there's a collision. WDYT @ahg-g ?

+1 for consistency. We can't use cs since it refers usually to a ClientSet instance, so I guess we can set the precedence that state in the context of the scheduler means CycleState.

done

[alculquicondor]

/lgtm

Thanks @draveness

[ahg-g]

/approve

[ahg-g]

/test pull-kubernetes-e2e-gce

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, draveness

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS [ahg-g]
• test/integration/scheduler/OWNERS [ahg-g]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[draveness]

/retest

[ahg-g]

/priority important-soon

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[draveness]

/retest Regards, Draven

…

On Oct 4, 2019, 2:58 PM +0800, Kubernetes Prow Robot ***@***.***>, wrote: @draveness: The following tests failed, say /retest to rerun them all: Test name Commit Details Rerun command pull-kubernetes-kubemark-e2e-gce-big 40df91e link /test pull-kubernetes-kubemark-e2e-gce-big pull-kubernetes-e2e-gce-100-performance 40df91e link /test pull-kubernetes-e2e-gce-100-performance pull-kubernetes-bazel-test 40df91e link /test pull-kubernetes-bazel-test pull-kubernetes-typecheck 40df91e link /test pull-kubernetes-typecheck pull-kubernetes-verify 40df91e link /test pull-kubernetes-verify Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[draveness]

Hi, @ahg-g. I just rebased the master and fixed the test, PTAL

[ahg-g]

/lgtm

[draveness]

/retest Regards, Draven

…

On Oct 4, 2019, 8:02 PM +0800, ahg-g ***@***.***>, wrote: /lgtm — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.