Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup reflection usage in framework creation #83506

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Cleanup reflection usage in framework creation #83506

merged 1 commit into from
Oct 4, 2019

Conversation

alculquicondor
Copy link
Member

@alculquicondor alculquicondor commented Oct 4, 2019 •
edited

/kind cleanup

What this PR does / why we need it:

Simplify implementation of updatePluginList, removing unnecessary parameter and reducing line length.

Outcome from #83460 (comment)

Notes to reviewer:

See simulation in playground https://play.golang.org/p/iwtz0nhMCod

Does this PR introduce a user-facing change?:

NONE

@alculquicondor
Cleanup reflection usage in framework creation
984c4e8 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 4, 2019
@alculquicondor
Copy link
Member Author

/assign @ahg-g

cc @draveness

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 4, 2019
@ahg-g
Copy link
Member

ahg-g commented Oct 4, 2019

/approve
/lgtm

nice!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2019
@alculquicondor
Copy link
Member Author

/test pull-kubernetes-e2e-gce-100-performance

/test pull-kubernetes-e2e-gce

1 similar comment
@alculquicondor
Copy link
Member Author

/test pull-kubernetes-e2e-gce-100-performance

/test pull-kubernetes-e2e-gce

@ahg-g ahg-g mentioned this pull request Oct 4, 2019
Merged
@k8s-ci-robot k8s-ci-robot merged commit 4e1214c into kubernetes:master Oct 4, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@wgliang wgliang Awaiting requested review from wgliang

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alculquicondor @ahg-g @k8s-ci-robot