Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plumbing for dynamic apiserver serving certificates #83580

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Plumbing for dynamic apiserver serving certificates #83580

merged 1 commit into from
Oct 17, 2019

Conversation

jackkleeman
Copy link
Contributor

@jackkleeman jackkleeman commented Oct 7, 2019 •
edited

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR is initial plumbing towards allowing apiserver default (non-SNI) serving certificates to be reloaded from disk. We change the Cert field in the SecureServingInfo to be a DynamicCertKeyContentProvider, which currently is implemented by a static provider that doesn't re-read off of disk, but this can change in a subsequent PR which will add a dynamic provider.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 7, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @jackkleeman. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 7, 2019
@k8s-ci-robot k8s-ci-robot added area/apiserver area/dependency Issues or PRs related to dependency changes sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 7, 2019
@jackkleeman
Copy link
Contributor Author

jackkleeman commented Oct 7, 2019 •
edited

/assign @deads2k

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 7, 2019
This was referenced Oct 7, 2019
Closed
Merged
@jackkleeman jackkleeman force-pushed the apiserver-cert-file-reload5 branch 2 times, most recently from 5dac194 to 010d2ba Compare October 12, 2019 12:13
@jackkleeman jackkleeman mentioned this pull request Oct 13, 2019
Closed
4 tasks
@jackkleeman jackkleeman force-pushed the apiserver-cert-file-reload5 branch 2 times, most recently from e0b3bda to 94e03bc Compare October 16, 2019 16:18
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 17, 2019
deads2k
deads2k reviewed Oct 17, 2019
View reviewed changes
staging/src/k8s.io/apiserver/pkg/server/dynamiccertificates/tlsconfig.go Outdated
return fmt.Errorf("invalid serving cert keypair: %v", err)
}

// error is not possible given above call to X509KeyPair
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check anyway please because I don't trust it.

@deads2k
Copy link
Contributor

deads2k commented Oct 17, 2019

/ok-to-test

minor comments only.
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, jackkleeman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2019
@deads2k
Copy link
Contributor

deads2k commented Oct 17, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2019
@jackkleeman
Plumb dynamic serving certificates
6f89f10 
We create and use a dynamic certificate provider for the main apiserver
serving certificates: SNI will be handled separately later. Currently we
only use static serving certificate providers, so the files are not
reloaded, but we should be able to move to a provider that is able to
reload later on.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2019
@deads2k
Copy link
Contributor

deads2k commented Oct 17, 2019

just a comment change

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2019
@jackkleeman
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@deads2k
Copy link
Contributor

deads2k commented Oct 17, 2019

/retest

@jackkleeman
Copy link
Contributor Author

/test pull-kubernetes-integration

@jackkleeman
Copy link
Contributor Author

jackkleeman commented Oct 17, 2019 •
edited

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit a78a403 into kubernetes:master Oct 17, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 17, 2019
@jackkleeman jackkleeman deleted the apiserver-cert-file-reload5 branch October 17, 2019 20:40
@jackkleeman jackkleeman mentioned this pull request Nov 12, 2019
Closed
6 tasks
@bhks
Copy link
Contributor

bhks commented Apr 17, 2020

Hi @jackkleeman and @deads2k ,

is it possible to just take this PR and have a cherry -pick to other k8s versions like 1.16 and 1.15 ?

What are the other changes or architecture we need to care about for this change to get merge in other k8s versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@nikhiljindal nikhiljindal Awaiting requested review from nikhiljindal

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jackkleeman @k8s-ci-robot @deads2k @bhks