Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Up minimum go version to 1.12.4 #83596

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Up minimum go version to 1.12.4 #83596

merged 1 commit into from
Oct 9, 2019

Conversation

jktomer
Copy link

@jktomer jktomer commented Oct 7, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
PR #77222 removed a workaround for a Go standard library bug that was not fixed until Go 1.12.4, so we need to require that version. (Building with Go versions prior to 1.12.4 will result in test failures in k8s.io/apimachinery/pkg/util/proxy, and of course actual failures if one uses the upgrade-aware proxy.)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Bumps the minimum version of Go required for building Kubernetes to 1.12.4.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Up minimum go version to 1.12.4
d34f49b 
kubernetes#77222 removed a workaround for a
Go standard library bug (golang/go#31125) that was
not fixed until that version, so we need to require it.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 7, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @jktomer. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 7, 2019
@jktomer
Copy link
Author

jktomer commented Oct 7, 2019

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Oct 7, 2019

/lgtm
/approve
/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 7, 2019
@jktomer
Copy link
Author

jktomer commented Oct 7, 2019

/retest

@k8s-ci-robot
Copy link
Contributor

@jktomer: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liggitt
Copy link
Member

liggitt commented Oct 8, 2019

/retest

@jktomer
Copy link
Author

jktomer commented Oct 8, 2019

/sig release

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 8, 2019
@logicalhan
Copy link
Member

/retest

@liggitt
Copy link
Member

liggitt commented Oct 8, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 8, 2019
@cblecker
Copy link
Member

cblecker commented Oct 8, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, jktomer, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jktomer
Copy link
Author

jktomer commented Oct 8, 2019

/test pull-kubernetes-e2e-gce-100-performance

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 6d97d36 into kubernetes:master Oct 9, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 9, 2019
@jktomer jktomer deleted the go-1-12-4 branch October 9, 2019 17:31
ohsewon pushed a commit to ohsewon/kubernetes that referenced this pull request Oct 16, 2019
@k8s-ci-robot @ohsewon
Merge pull request kubernetes#83596 from jktomer/go-1-12-4
cfb1c79 
Up minimum go version to 1.12.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker Awaiting requested review from cblecker

@ixdy ixdy Awaiting requested review from ixdy

Assignees

@liggitt liggitt

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jktomer @k8s-ci-robot @liggitt @logicalhan @cblecker @fejta-bot