Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added alejandrox1 as test/* reviewer #83616

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Added alejandrox1 as test/* reviewer #83616

merged 1 commit into from
Oct 8, 2019

Conversation

alejandrox1
Copy link
Contributor

Signed-off-by: alejandrox1 alarcj137@gmail.com

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Added myself as reviewer for test/*

Does this PR introduce a user-facing change?:

NONE

@alejandrox1
Added alejandrox1 as test/* reviewer
dc90f99 
Signed-off-by: alejandrox1 <alarcj137@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 8, 2019
@alejandrox1
Copy link
Contributor Author

/priority backlog
/sig testing

/assign @timothysc @oomichi
ptal

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 8, 2019
neolit123
neolit123 reviewed Oct 8, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
from me. thanks for the efforts.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2019
timothysc
timothysc approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alejandrox1, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2019
@alejandrox1
Copy link
Contributor Author

/lgtm
from me. thanks for the efforts.

Thank you Lubomir, Tim!

/test pull-kubernetes-e2e-kind

@oomichi
Copy link
Member

oomichi commented Oct 8, 2019

Oh, I didn't think @alejandrox1 was not a reviewer yet.
Thanks for your contribution.

/lgtm

@alejandrox1
Copy link
Contributor Author

alejandrox1 commented Oct 8, 2019 •
edited

/test pull-kubernetes-e2e-gce

prev err https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/83616/pull-kubernetes-e2e-gce/1181631930639060992/

@k8s-ci-robot k8s-ci-robot merged commit 384e03a into kubernetes:master Oct 8, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 8, 2019
@alejandrox1 alejandrox1 deleted the add-alejandrox1-test-eviewer branch October 8, 2019 20:42
ohsewon pushed a commit to ohsewon/kubernetes that referenced this pull request Oct 16, 2019
@k8s-ci-robot @ohsewon
Merge pull request kubernetes#83616 from alejandrox1/add-alejandrox1-…
8668e2c 
…test-eviewer

Added alejandrox1 as test/* reviewer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@timothysc timothysc timothysc approved these changes

@draveness draveness Awaiting requested review from draveness

Assignees

@timothysc timothysc

@neolit123 neolit123

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alejandrox1 @k8s-ci-robot @oomichi @timothysc @neolit123