Use latest node-cache version with stubdomain fix. #83707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This image fixed a bug in configuring stubDomains and caused test failure - https://k8s-testgrid.appspot.com/sig-network-gce#gci-gce-serial-kube-dns-nodecache Verified by running the same test locally.
k8s-ci-robot
added
release-note-none
|
/sig network |
k8s-ci-robot
added
sig/network
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
|
/assign @MrHohn |
|
/assign @bowei |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrHohn, prameshj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
ohsewon
pushed a commit
to ohsewon/kubernetes
that referenced
this pull request
Oct 16, 2019
Use latest node-cache version with stubdomain fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This image fixed a bug in configuring stubDomains and caused test
failure - https://k8s-testgrid.appspot.com/sig-network-gce#gci-gce-serial-kube-dns-nodecache
Verified by running the same test locally.
./hack/ginkgo-e2e.sh --ginkgo.focus="stubDomain" --report-dir=/workspace/_artifacts --disable-log-dump=true
What type of PR is this?
What this PR does / why we need it:
This image fixed a bug in configuring stubDomains and caused test failure - https://k8s-testgrid.appspot.com/sig-network-gce#gci-gce-serial-kube-dns-nodecache
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: