Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix staticcheck failures in test/e2e/windows #83714

Merged
merged 1 commit into from Nov 27, 2019
Merged

fix staticcheck failures in test/e2e/windows #83714

merged 1 commit into from Nov 27, 2019

Conversation

tanjunchen
Copy link
Member

@tanjunchen tanjunchen commented Oct 10, 2019 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Fix the staticcheck failures for test/e2e/windows

Which issue(s) this PR fixes:
Ref #81657

Special notes for your reviewer:

density.go:79:2: field bgPodsNr is unused (U1000)
density.go:87:2: field cpuLimits is unused (U1000)
density.go:88:2: field memLimits is unused (U1000)
density.go: 100:45: should use make(map[string]metav1.Time) instead (S1019)
density.go:281:2: redundant return statement (S1023)
dns.go:31:7: const dnsTestPodHostName is unused (U1000)
dns.go:32:7: const dnsTestServiceName is unused (U1000)
dns.go:78:13: this value of err is never used (SA4006)
security_context.go:53:6: don't use Yoda conditions (ST1017)

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 10, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @tanjunchen. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 10, 2019
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 11, 2019
@k8s-ci-robot
Copy link
Contributor

@tanjunchen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hwdef
Copy link
Member

hwdef commented Oct 11, 2019

Thank you!
/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2019
@tanjunchen
Copy link
Member Author

/assign @spiffxp
/assign @liggitt
thanks :)

@michmike
Copy link
Contributor

michmike commented Nov 5, 2019

cc: @adelina-t

1 similar comment
@tanjunchen
Copy link
Member Author

cc: @adelina-t

@adelina-t
Copy link
Contributor

Looks ok, I'm waiting for a test run to approve

@claudiubelu
Copy link
Contributor

/lgtm

Tests are not affected in any negative way.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2019
@tanjunchen
Copy link
Member Author

@adelina-t @BCLAU
Thanks

@k8s-ci-robot k8s-ci-robot added do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 14, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Nov 15, 2019
@tanjunchen
Copy link
Member Author

/test pull-kubernetes-integration

@tanjunchen
Copy link
Member Author

@adelina-t any questions?this pr is open too long.

alejandrox1
alejandrox1 reviewed Nov 26, 2019
View reviewed changes
Copy link
Contributor

@alejandrox1 alejandrox1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. thank you @tanjunchen !
/lgtm
/priority backlog

pinging hack/windows owners for final approval
cc @michmike @PatrickLang

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 26, 2019
@adelina-t
Copy link
Contributor

As mentioned above, from windows tests perspective it's fine by me.

@adelina-t
Copy link
Contributor

/approve

@tanjunchen
Copy link
Member Author

/assign @liggitt

@PatrickLang
Copy link
Contributor

/approve
thanks!

@liggitt
Copy link
Member

liggitt commented Nov 27, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adelina-t, liggitt, PatrickLang, tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2019
@tanjunchen
Copy link
Member Author

/test pull-kubernetes-integration

1 similar comment
@tanjunchen
Copy link
Member Author

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit 6a48f55 into kubernetes:master Nov 27, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Nov 27, 2019
@tanjunchen tanjunchen deleted the fix-staticcheck-test/e2e/windows branch January 4, 2020 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@alejandrox1 alejandrox1 alejandrox1 left review comments

@dineshgovindasamy dineshgovindasamy Awaiting requested review from dineshgovindasamy

@vishh vishh Awaiting requested review from vishh

Assignees

@spiffxp spiffxp

@sttts sttts

@liggitt liggitt

@claudiubelu claudiubelu

@alejandrox1 alejandrox1

@PatrickLang PatrickLang

@hwdef hwdef

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet