Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off proxy metrics that have been deprecated #83839

Merged
merged 1 commit into from Nov 14, 2019
Merged

Turn off proxy metrics that have been deprecated #83839

merged 1 commit into from Nov 14, 2019

Conversation

RainbowMango
Copy link
Member

@RainbowMango RainbowMango commented Oct 12, 2019 •
edited

What type of PR is this?
/kind feature

What this PR does / why we need it:
Turn off metrics that have been deprecated.

Refer to kubernetes/enhancements#1206:

Kubernetes 1.17 will remove the in 1.14 marked as deprecated metrics. As a stretch goal, if the metrics stability framework is in place, then in Kubernetes 1.17 the metrics will only be turned off by default through the stability framework. Should this not be available, then the metrics will be removed.

Which issue(s) this PR fixes:
Part of kubernetes/enhancements#1206

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Deprecated metric `kubeproxy_sync_proxy_rules_latency_microseconds` has been turned off.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/da4b7050ccae7a947e4d60f94ab28513e513a458/keps/sig-instrumentation/20181106-kubernetes-metrics-overhaul.md

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 12, 2019
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 12, 2019
@RainbowMango
Copy link
Member Author

/retest

@BenTheElder BenTheElder mentioned this pull request Oct 13, 2019
Merged
@RainbowMango
Copy link
Member Author

Sorry to bother you. Maybe this triggered a potential bug, I need to investigate more.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2019
@RainbowMango RainbowMango mentioned this pull request Oct 14, 2019
Closed
@RainbowMango
Copy link
Member Author

Rely on #84135. Let's continue after that.

@RainbowMango RainbowMango force-pushed the pr_hide_proxy_deprecated_metrics branch from 8571b8f to 26b9374 Compare November 11, 2019 13:02
@RainbowMango RainbowMango mentioned this pull request Nov 11, 2019
Merged
@RainbowMango
Copy link
Member Author

/hold cancel
/cc @logicalhan @brancz
/cc @MrHohn

/priority important-soon

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2019
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 12, 2019
@RainbowMango RainbowMango force-pushed the pr_hide_proxy_deprecated_metrics branch from 26b9374 to 9f013cb Compare November 13, 2019 11:31
@RainbowMango
Copy link
Member Author

/assign @MrHohn

@brancz
Copy link
Member

brancz commented Nov 13, 2019

Looks good from instrumentation side.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2019
@RainbowMango
Copy link
Member Author

/test pull-kubernetes-node-e2e-containerd

1 similar comment
@RainbowMango
Copy link
Member Author

/test pull-kubernetes-node-e2e-containerd

@RainbowMango RainbowMango mentioned this pull request Nov 13, 2019
Closed
@RainbowMango
Copy link
Member Author

/test pull-kubernetes-node-e2e-containerd

@RainbowMango
Copy link
Member Author

I guess something wrong with the pull-kubernetes-node-e2e-containerd.
retry again.

/test pull-kubernetes-node-e2e-containerd

MrHohn
MrHohn approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, MrHohn, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@RainbowMango
Copy link
Member Author

/test pull-kubernetes-integration
/test pull-kubernetes-kubemark-e2e-gce-big

@k8s-ci-robot k8s-ci-robot merged commit 1ae9713 into kubernetes:master Nov 14, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 14, 2019
@RainbowMango RainbowMango deleted the pr_hide_proxy_deprecated_metrics branch December 10, 2019 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancz brancz brancz left review comments

@MrHohn MrHohn MrHohn approved these changes

@danwinship danwinship Awaiting requested review from danwinship

@dineshgovindasamy dineshgovindasamy Awaiting requested review from dineshgovindasamy

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@brancz brancz

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@RainbowMango @brancz @k8s-ci-robot @fejta-bot @MrHohn