feat(scheduler): implement NodePreferAvoidPods as score plugin #83893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
draveness
force-pushed
the
feature/node-prefer-avoid-pods
branch
2 times, most recently
from
8619d1b
to
459becc
Compare
draveness
force-pushed
the
feature/node-prefer-avoid-pods
branch
from
459becc
to
2d7044a
Compare
ahg-g
reviewed
Oct 14, 2019
Comment on lines
+135
to
+159
| var gotList framework.NodeScoreList | ||
| for _, n := range test.nodes { | ||
| nodeName := n.ObjectMeta.Name | ||
| score, status := p.(framework.ScorePlugin).Score(state, test.pod, nodeName) | ||
| if !status.IsSuccess() { | ||
| t.Errorf("unexpected error: %v", status) | ||
| } | ||
| gotList = append(gotList, framework.NodeScore{Name: nodeName, Score: score}) | ||
| } |
There was a problem hiding this comment.
This can be a function I guess. It would be nice if we have a plugins/testing/utils.go package that includes functions to aid testing like this one, which I expect all score plugins to use. We can do that in a follow up PR though.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, draveness The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
|
the kubemark-big job has failed on 37 batch merges that included this PR /test pull-kubernetes-kubemark-e2e-gce-big |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/hold cancel since the other one is on hold now. |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind cleanup
/assign @ahg-g
Which issue(s) this PR fixes:
Fixes #83770
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: