Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove update-storage-objects.sh #83969

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Remove update-storage-objects.sh #83969

merged 1 commit into from
Oct 16, 2019

Conversation

tedyu
Copy link
Contributor

@tedyu tedyu commented Oct 15, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
As #69299 stated, cluster/update-storage-objects.sh is subsumed by kubernetes/community#2524

Which issue(s) this PR fixes:
Fixes #69299

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 15, 2019
@tedyu
Copy link
Contributor Author

tedyu commented Oct 15, 2019

/assign @caesarxuchao

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 15, 2019
@caesarxuchao
Copy link
Member

Though the storage migrator is not ready yet, these scripts are outdated and not useful, so removing them lgtm.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2019
@dims
Copy link
Member

dims commented Oct 15, 2019

Thanks @caesarxuchao! for making my review easier :)

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, dims, tedyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2019
@tedyu
Copy link
Contributor Author

tedyu commented Oct 15, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 44674bf into kubernetes:master Oct 16, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 16, 2019
@superbrothers
Copy link
Member

superbrothers commented Dec 16, 2019 •
edited

@tedyu @caesarxuchao

Though the storage migrator is not ready yet, these scripts are outdated and not useful, so removing them lgtm.

So, how do we update storage objects instead? You said the kube-storage-version-migrator is not ready yet. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eparis eparis Awaiting requested review from eparis

@vishh vishh Awaiting requested review from vishh

Assignees

@caesarxuchao caesarxuchao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

Remove cluster/update-storage-objects.sh and hack/test-update-storage-objects.sh
6 participants
@tedyu @caesarxuchao @dims @k8s-ci-robot @superbrothers @yutedz