cleanup unnecessary func parameters in genericScheduler methods #84015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
k8s-ci-robot
removed
the
needs-rebase
|
/assign @liu-cong |
|
/test pull-kubernetes-integration |
1 similar comment
|
/test pull-kubernetes-integration |
liu-cong
reviewed
Oct 17, 2019
| filterPlugin.failedNodeReturnCodeMap = filterFailedNodeReturnCodeMap | ||
| scheduler := NewGenericScheduler( | ||
| nil, | ||
| internalqueue.NewSchedulingQueue(nil, nil), | ||
| test.predicates, | ||
| predMetaProducer, | ||
| PredicateMetadata, |
There was a problem hiding this comment.
nit: The PredicateMetadata is a one-liner. Seems that it can be removed. At least it doesn't need to be exported.
|
/lgtm You need to resolve conflicts. |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
done. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
a number of functions are now private to genericScheduler, and so many of the parameters they receive already exist in the object and need not be passed.