make sure filters are executed when no predicates configured #84028
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
sig/scheduling
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
removed
the
needs-rebase
| @@ -458,7 +458,7 @@ func (g *genericScheduler) findNodesThatFit(state *framework.CycleState, pod *v1 | |||
| failedPredicateMap := FailedPredicateMap{} | |||
| filteredNodesStatuses := framework.NodeToStatusMap{} | |||
|
|
|||
| if len(g.predicates) == 0 { | |||
| if len(g.predicates) == 0 && !g.framework.HasFilterPlugins() { | |||
There was a problem hiding this comment.
Will there be any default filter plugins if not configured?
There was a problem hiding this comment.
I am not sure what you mean, but the else clause should be executed if there is at least one filter or predicate to evaluate.
There was a problem hiding this comment.
There will be default plugins configured, but how is this relevant to this line?
There was a problem hiding this comment.
Sorry, I checked the code again, it works.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently framework filters will not be executed if not predicates are configured, this shouldn't be the case.