Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cluster Autoscaler version to 1.16.2 #84038

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Update Cluster Autoscaler version to 1.16.2 #84038

merged 1 commit into from
Oct 18, 2019

Conversation

losipiuk
Copy link
Contributor 

Update Cluster Autoscaler version to 1.16.2 (CA release docs: https://github.com/kubernetes/autoscaler/releases/tag/cluster-autoscaler-1.16.2)

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 17, 2019
@losipiuk
Copy link
Contributor Author

/retest

4 similar comments
@losipiuk
Copy link
Contributor Author

/retest

@losipiuk
Copy link
Contributor Author

/retest

@losipiuk
Copy link
Contributor Author

/retest

@losipiuk
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@losipiuk: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gci-gce-autoscaling efe79f2 link /test pull-kubernetes-e2e-gci-gce-autoscaling

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@losipiuk losipiuk changed the title [WIP] Update Cluster Autoscaler version to 1.16.2 Update Cluster Autoscaler version to 1.16.2 Oct 18, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2019
@losipiuk
Copy link
Contributor Author

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 18, 2019
@losipiuk
Copy link
Contributor Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 18, 2019
@losipiuk
Copy link
Contributor Author

/assign @tallclair PTAL.

To validate CA manifest updates like this one I added a non obligatory presubmit which runs all CA tests if manifest is changed.
The result is mostly green https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/84038/pull-kubernetes-e2e-gci-gce-autoscaling/1184894942527361024/. One test failed - but that one is flaking a lot.

mwielgus
mwielgus approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: losipiuk, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2019
@losipiuk losipiuk mentioned this pull request Oct 18, 2019
Merged
@k8s-ci-robot k8s-ci-robot merged commit 54a3070 into kubernetes:master Oct 18, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 18, 2019
k8s-ci-robot added a commit that referenced this pull request Oct 29, 2019
@k8s-ci-robot
Merge pull request #84087 from losipiuk/automated-cherry-pick-of-#840…
c1f40a5 
…38-upstream-release-1.16

Automated cherry pick of #84038: Update Cluster Autoscaler version to 1.16.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus mwielgus approved these changes

@MrHohn MrHohn Awaiting requested review from MrHohn

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@losipiuk @k8s-ci-robot @mwielgus