Close the file after reading in verifydependencies#main #84108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/sig release |
k8s-ci-robot
added
sig/release
|
/lgtm |
k8s-ci-robot
added
priority/backlog
|
/assign @dims |
justaugustus
requested changes
Oct 19, 2019
There was a problem hiding this comment.
@tedyu -- hey, can you update the commit message and PR title to be explicit about what file you're referring to?
tedyu
changed the title
yutedz
force-pushed
the
verify-dep-close
branch
from
15c80d2
to
dd557e3
Compare
k8s-ci-robot
removed
the
lgtm
|
@justaugustus |
|
Thanks! |
k8s-ci-robot
added
the
lgtm
yutedz
force-pushed
the
verify-dep-close
branch
from
dd557e3
to
a7231fc
Compare
k8s-ci-robot
added
size/M
neolit123
reviewed
Oct 19, 2019
| if matcher.MatchString(line) && strings.Contains(line, dep.Version) { | ||
| found = true | ||
| break | ||
| func() { |
There was a problem hiding this comment.
nit: i would have declared a function for this instead of using a lambda.
/lgtm
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, justaugustus, tedyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-kubernetes-integration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
For verifydependencies, in the main() func, after the file is done being read, we should close it.
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: