New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[k8s.io/sample-controller/controller.go]: fixup minor typo #84327
Conversation
Signed-off-by: Zhou Peng <p@ctriple.cn>
Hi @byteor. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind flake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @munnerz
for approval
/remove-kind flake
/kind cleanup
/release-note-none
/priority backlog
/ok-to-test
/retest
…On Fri, Oct 25, 2019 at 10:28 AM Kubernetes Prow Robot < ***@***.***> wrote:
@byteor <https://github.com/byteor>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-kubemark-e2e-gce-big 5616ce9
<5616ce9>
link
<https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/84327/pull-kubernetes-kubemark-e2e-gce-big/1187585574559551488/> /test
pull-kubernetes-kubemark-e2e-gce-big
Full PR test history
<https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=84327>. Your
PR dashboard <https://gubernator.k8s.io/pr/byteor>. Please help us cut
down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#84327?email_source=notifications&email_token=AD24BUFTXSFQHL3AP73TRKLQQJ4IJA5CNFSM4JE5XO5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECHFXLQ#issuecomment-546200494>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD24BUE4EH6575LNICNSEYDQQJ4IJANCNFSM4JE5XO5A>
.
|
/retest
…On Fri, Oct 25, 2019 at 11:43 AM Kubernetes Prow Robot < ***@***.***> wrote:
@byteor <https://github.com/byteor>: The following tests *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-kubemark-e2e-gce-big 5616ce9
<5616ce9>
link
<https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/84327/pull-kubernetes-kubemark-e2e-gce-big/1187585574559551488/> /test
pull-kubernetes-kubemark-e2e-gce-big
pull-kubernetes-e2e-gce-100-performance 5616ce9
<5616ce9>
link
<https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/84327/pull-kubernetes-e2e-gce-100-performance/1187585574517608448/> /test
pull-kubernetes-e2e-gce-100-performance
Full PR test history
<https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=84327>. Your
PR dashboard <https://gubernator.k8s.io/pr/byteor>. Please help us cut
down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#84327?email_source=notifications&email_token=AD24BUBZE25COYUOZIAGX33QQKFBPA5CNFSM4JE5XO5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECHJQ5Y#issuecomment-546216055>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD24BUFBHG7CUVPPNGZOQTTQQKFBPANCNFSM4JE5XO5A>
.
|
@munnerz 👋 for approval |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: byteor, munnerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Zhou Peng p@ctriple.cn
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: