Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate e2enetwork from e2e core framework #84379

Merged
merged 1 commit into from Oct 31, 2019
Merged

Separate e2enetwork from e2e core framework #84379

merged 1 commit into from Oct 31, 2019

Conversation

oomichi
Copy link
Member

@oomichi oomichi commented Oct 25, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

networking_utils.go is only for network tests and it is nice to
separate it from the core framework for easy maintenance.

Special notes for your reviewer:

This is one of the work for reducing invalid dependencies to subpackages of e2e framework from
the core framework as #81427

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 25, 2019
Separate e2enetwork from e2e core framework
5d6faad 
networking_utils.go is only for network tests and it is nice to
separate it from the core framework for easy maintenance.
@oomichi oomichi changed the title WIP: Separate e2enetwork from e2e core framework Separate e2enetwork from e2e core framework Oct 25, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2019
@oomichi
Copy link
Member Author

oomichi commented Oct 25, 2019

/retest

@timothysc
Copy link
Member

/assign @alejandrox1 @andrewsykim

@aojea
Copy link
Member

aojea commented Oct 28, 2019

/test pull-kubernetes-e2e-kind-ipv6

@k-toyoda-pi
Copy link
Contributor

Thank you for cleanup.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit dda78d5 into kubernetes:master Oct 31, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 31, 2019
@kidlj kidlj mentioned this pull request Apr 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adelina-t adelina-t Awaiting requested review from adelina-t

@bskiba bskiba Awaiting requested review from bskiba

Assignees

@alejandrox1 alejandrox1

@andrewsykim andrewsykim

@k-toyoda-pi k-toyoda-pi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@oomichi @k8s-ci-robot @timothysc @aojea @k-toyoda-pi @alejandrox1 @andrewsykim