Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RequestedToCapacityRatio as score plugin #84520

Merged
merged 1 commit into from Oct 30, 2019
Merged

RequestedToCapacityRatio as score plugin #84520

merged 1 commit into from Oct 30, 2019

Conversation

mrkm4ntr
Copy link
Contributor

@mrkm4ntr mrkm4ntr commented Oct 29, 2019 •
edited

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
Converted RequestedToCapacityRatio to a score plugin.

Which issue(s) this PR fixes:

Fixes #84458

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/priority important-soon

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 29, 2019
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 29, 2019
@mrkm4ntr mrkm4ntr force-pushed the migrate-requested-to-capacity-ratio branch from 9c4f2a8 to 2903ffe Compare October 29, 2019 17:51
@ahg-g
Copy link
Member

ahg-g commented Oct 29, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
Converted RequestedToCapacityRatio to a score plugin.

Which issue(s) this PR fixes:

Fixes #84458

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

User can now use component config to configure RequestedToCapacityRatio plugin for the scheduler framework.

While technically true, it is not something we want to officially support now, please remove this release note for now.

ahg-g
ahg-g reviewed Oct 29, 2019
View reviewed changes
pkg/scheduler/framework/plugins/default_registry.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/requestedtocapacityratio/requested_to_capacity_ratio.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/requestedtocapacityratio/requested_to_capacity_ratio_test.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/requestedtocapacityratio/requested_to_capacity_ratio_test.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/requestedtocapacityratio/requested_to_capacity_ratio_test.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/requestedtocapacityratio/requested_to_capacity_ratio_test.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/requestedtocapacityratio/requested_to_capacity_ratio_test.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/requestedtocapacityratio/requested_to_capacity_ratio_test.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/requestedtocapacityratio/requested_to_capacity_ratio_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 29, 2019
@mrkm4ntr mrkm4ntr force-pushed the migrate-requested-to-capacity-ratio branch from 2903ffe to d8f7ca5 Compare October 30, 2019 00:29
@mrkm4ntr
Copy link
Contributor Author

/retest

ahg-g
ahg-g reviewed Oct 30, 2019
View reviewed changes
Copy link
Member

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit.

pkg/scheduler/framework/plugins/default_registry.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/plugins/default_registry.go Outdated Show resolved Hide resolved
@mrkm4ntr mrkm4ntr force-pushed the migrate-requested-to-capacity-ratio branch from d8f7ca5 to 4b72af9 Compare October 30, 2019 13:00
@ahg-g
Copy link
Member

ahg-g commented Oct 30, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, mrkm4ntr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit 409b468 into kubernetes:master Oct 30, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi left review comments

@ahg-g ahg-g ahg-g left review comments

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

RequestedToCapacityRatio as score plugin
4 participants
@mrkm4ntr @ahg-g @k8s-ci-robot @damemi