switched to use the pause image served from gcr #84538
Conversation
k8s-ci-robot
added
kind/cleanup
| @@ -51,7 +51,7 @@ | |||
| # - Document functions using proper syntax: | |||
| # https://technet.microsoft.com/en-us/library/hh847834(v=wps.620).aspx | |||
|
|
|||
| $INFRA_CONTAINER = 'mcr.microsoft.com/k8s/core/pause:1.0.0' | |||
| $INFRA_CONTAINER = 'gcr.io/gke-release/pause-win:1.0.0' | |||
There was a problem hiding this comment.
To clarify: is this GCR bucket available to any user, not just google-owned projects?
There was a problem hiding this comment.
Yes, it is available to public.
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
/test pull-kubernetes-e2e-windows-gce |
|
/retest |
|
/test pull-kubernetes-integration |
| @@ -159,6 +158,8 @@ try { | |||
|
|
|||
| $config = New-FileRotationConfig | |||
| Schedule-LogRotation -Pattern '.*\.log$' -Path ${env:LOGS_DIR} -RepetitionInterval $(New-Timespan -Hour 1) -Config $config | |||
|
|
|||
| Pull-InfraContainer | |||
There was a problem hiding this comment.
What's the reason for this change?
On one hand I suppose this should let the node join the cluster more quickly. On the other hand there could be some delay if a user tries to run a Windows pod immediately after the node is Ready but the pause container hasn't finished pulling yet.
There was a problem hiding this comment.
it is not needed for kubelet/node to register with the master/control plane. Pull-InfraContainer is a best-effort optimization, so that when a user start a pod, the 'pause' image is likely already present on the node. Moving it to the last would 1) shorten the delay for the node to join the cluster, [so user can submit deployment/pod earlier, user does not need to wait for the node to be ready to submit deployment/pod in theory, but in practice, user may wait/check for node to be ready before deploying anything] 2) no worse than current situation (should be better) in terms of user-perceived node startup time. [we may explore moving it to the first step when making it async/pulling in the background]
There was a problem hiding this comment.
Makes sense, thanks for clarifying.
There was a problem hiding this comment.
It doesn't seem safe to move this.
Windows image pull is slow, for docker pulling the pause image can takes >4min, for containerd it is even longer...
If the pause image is not prepulled before the node is ready, it is possible that a user will never be able to create a pod.
The reason is that in kubelet we set a 4min timeout for pod sandbox start (including pulling the pause image) https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/remote/remote_runtime.go#L97.
If the pause image is not prepulled, RunPodSandbox may timeout every time, abort the ongoing pulling, and try pulling again. If for any reason the pause image pull is longer than 4min, the image pull may be always aborted, thus the pod can't start any more.
For Docker, I believe this may happen, and for containerd, because of the slow image pull this breaks the test.
There was a problem hiding this comment.
If the pause image is not prepulled, RunPodSandbox may timeout every time, abort the ongoing pulling, and try pulling again.
This doesn't sound like the right thing to do on Windows. Can/should we change that behavior?
There was a problem hiding this comment.
chatted offline about it.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pjh, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest Review the full test history for this PR. Silence the bot with an |
|
/retest |
|
@yliaog: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
What this PR does / why we need it:
switched to use the pause image served from gcr
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: