Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose filteredNodes to func PriorityMetadataProducer #84542

Merged
merged 1 commit into from Oct 30, 2019

Conversation

Huang-Wei
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Due to some historical reason, some Priorities are not written in the map-reduce style, in particular PodAffinity and EvenPodsSpread. To make sure they can refactored into map-reduce style, their specific internal helper data structure must be calculated in PriorityMetadataProducer, and unfortunately current PriorityMetadataProducer signature doesn't expose the filteredNoded, which is needed for those 2 Priorities. This PR adds the additional filteredNoded in PriorityMetadataProducer.

Which issue(s) this PR fixes:

The migration of PodAffinity and EvenPodsSpread Priority is dependent on this.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

/sig scheduling
/assign @ahg-g

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 30, 2019
@ahg-g
Copy link
Member

ahg-g commented Oct 30, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 87c60f3 into kubernetes:master Oct 30, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 30, 2019
@Huang-Wei Huang-Wei deleted the priority-meta-signature branch October 30, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants