Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golint issues in pkg/controller/volume/persistentvolume/options #84748

Merged
merged 1 commit into from Nov 7, 2019
Merged

Fix golint issues in pkg/controller/volume/persistentvolume/options #84748

merged 1 commit into from Nov 7, 2019

Conversation

hvaara
Copy link
Contributor

@hvaara hvaara commented Nov 4, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR fixes golint issues in pkg/controller/volume/persistentvolume/options

Which issue(s) this PR fixes:
Ref #68026

Special notes for your reviewer:
None

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 4, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @hvaara. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 4, 2019
@hvaara
Copy link
Contributor Author

hvaara commented Nov 4, 2019

/sig storage
/priority backlog
/area code-organization

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. priority/backlog Higher priority than priority/awaiting-more-evidence. area/code-organization Issues or PRs related to kubernetes code organization and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 4, 2019
@hvaara
Copy link
Contributor Author

hvaara commented Nov 5, 2019

/assign @jsafrane @SataQiu

@msau42
Copy link
Member

msau42 commented Nov 6, 2019

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 6, 2019
@hvaara
Copy link
Contributor Author

hvaara commented Nov 6, 2019

/retest

2 similar comments
@hvaara
Copy link
Contributor Author

hvaara commented Nov 6, 2019

/retest

@hvaara
Copy link
Contributor Author

hvaara commented Nov 6, 2019

/retest

SataQiu
SataQiu approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hvaara !
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hvaara, msau42, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1183771 into kubernetes:master Nov 7, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 7, 2019
@hvaara hvaara deleted the fix-golint-controller-volume-persistentvolume-options branch November 7, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SataQiu SataQiu SataQiu approved these changes

@msau42 msau42 Awaiting requested review from msau42

@vishh vishh Awaiting requested review from vishh

Assignees

@jsafrane jsafrane

@SataQiu SataQiu

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-organization Issues or PRs related to kubernetes code organization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hvaara @k8s-ci-robot @msau42 @SataQiu @jsafrane