kubeadm: Amend the hyperkube deprecation change #85137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
the
kind/cleanup
k8s-ci-robot
added
sig/cluster-lifecycle
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rosti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
The PR introducing 5bb8069 got merged accidentally (the CI robot not respecting a hold). Hence, the feedback to that PR is merged separately. Signed-off-by: Rostislav M. Georgiev <rostislavg@vmware.com>
rosti
force-pushed
the
kubeadm-amend-hyperkube-deprecation
branch
from
ee6dbab
to
ec4840f
Compare
k8s-ci-robot
removed
the
lgtm
|
Updated by marking the internal |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
|
/retest |
1 similar comment
|
/retest |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
As #85094 got merged accidentally (the CI robot not respecting a
/hold) we need to amend it with the feedback separately.Which issue(s) this PR fixes:
Refs kubernetes/kubeadm#1889
Special notes for your reviewer:
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews
/area kubeadm
/priority important-soon
/assign @neolit123 @ereslibre @fabriziopandini
/cc @yastij
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: