Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote apiserver.config.k8s.io/v1, kind=WebhookAdmissionConfiguration #85138

Merged
merged 1 commit into from Nov 13, 2019
Merged

Promote apiserver.config.k8s.io/v1, kind=WebhookAdmissionConfiguration #85138

merged 1 commit into from Nov 13, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Nov 12, 2019 •
edited

This promotes the WebhookAdmissionConfiguration config file version to apiserver.config.k8s.io/v1 API group. The corresponding feature (mutating/validating webhook admission) went to v1 in 1.16.0

This PR:

  • This promotes apiserver.config.k8s.io/v1alpha1, kind=WebhookAdmission to apiserver.config.k8s.io/v1, kind=WebhookAdmissionConfiguration
    • The Configuration suffix is used consistently for top-level configuration types
  • adds unit tests for decoding v1alpha1 and v1 configs
  • docs update in Update WebhookAdmissionConfiguration example website#17549
kube-apiserver: Authentication configuration for mutating and validating admission webhooks referenced from an `--admission-control-config-file` can now be specified with `apiVersion: apiserver.config.k8s.io/v1, kind: WebhookAdmissionConfiguration`.

/sig api-machinery
/cc @deads2k

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver labels Nov 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member Author

liggitt commented Nov 12, 2019

/kind cleanup
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 12, 2019
@liggitt liggitt mentioned this pull request Nov 12, 2019
Merged
@liggitt liggitt changed the title Promote WebhookAdmissionConfiguration to v1 Promote apiserver.config.k8s.io/v1, kind=WebhookAdmissionConfiguration Nov 12, 2019
@liggitt liggitt added this to the v1.17 milestone Nov 12, 2019
@deads2k
Copy link
Contributor

deads2k commented Nov 13, 2019

/lgtm

mismatching the struct and serialization is annoying, but I guess we should deal with it until we drop the alpha version in a year or so.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2019
@ahg-g
Copy link
Member

ahg-g commented Nov 13, 2019

/retest

@liggitt
Copy link
Member Author

liggitt commented Nov 13, 2019

the pull-kubernetes-node-e2e-containerd failure is known, not a flake, non-blocking, and being worked on - #85040

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

k8s-ci-robot added a commit that referenced this pull request Nov 13, 2019
@k8s-ci-robot
Merge pull request #85138 from liggitt/webhook-config-v1
f501d8e 
Promote apiserver.config.k8s.io/v1, kind=WebhookAdmissionConfiguration
@k8s-ci-robot k8s-ci-robot merged commit f501d8e into kubernetes:master Nov 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit 71fad81 into kubernetes:master Nov 13, 2019
@liggitt liggitt deleted the webhook-config-v1 branch November 14, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liggitt @k8s-ci-robot @deads2k @ahg-g @fejta-bot