Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler: make algorithm source an option #85151

Merged
merged 1 commit into from Nov 13, 2019
Merged

scheduler: make algorithm source an option #85151

merged 1 commit into from Nov 13, 2019

Conversation

hypnoglow
Copy link
Contributor

@hypnoglow hypnoglow commented Nov 12, 2019 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Changes scheduler.New so that the algorithm source is moved from the parameter to an option. The default algorithm source is a source with the DefaultProvider.

Which issue(s) this PR fixes:

Fixes #85140

Special notes for your reviewer:

Raised on kubernetes/autoscaler#2515 (comment)

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/priority backlog
/sig scheduling

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 12, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @hypnoglow. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 12, 2019
@hypnoglow
Copy link
Contributor Author

/assign @k82cn @krzyzacy @alculquicondor

@ahg-g
Copy link
Member

ahg-g commented Nov 12, 2019

/approve

@ahg-g
Copy link
Member

ahg-g commented Nov 12, 2019

/assign @msau42

for test/OWNERS changes.

@ahg-g
Copy link
Member

ahg-g commented Nov 12, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 12, 2019
@ahg-g
Copy link
Member

ahg-g commented Nov 12, 2019

/milestone v1.17

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 12, 2019
@alculquicondor
Copy link
Member

/remove-kind feature
/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Nov 12, 2019
@alculquicondor
Copy link
Member

Please call ./hack/update-bazel.sh

@msau42
Copy link
Member

msau42 commented Nov 13, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, hypnoglow, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2019
@hypnoglow
scheduler: make algorithm source an option
6350095 
Changes scheduler.New so that algorithm source is moved from the
parameter to an option. The default algorithm source is source with the
DefaultProvider.
@hypnoglow
Copy link
Contributor Author

Please call ./hack/update-bazel.sh

Done

@alculquicondor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2019
@ahg-g ahg-g mentioned this pull request Nov 13, 2019
Merged
@k8s-ci-robot k8s-ci-robot merged commit 7d15802 into kubernetes:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@alejandrox1 alejandrox1 Awaiting requested review from alejandrox1

Assignees

@krzyzacy krzyzacy

@alculquicondor alculquicondor

@k82cn k82cn

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

Make algorithm source an option of scheduler.New
7 participants
@hypnoglow @k8s-ci-robot @ahg-g @alculquicondor @msau42 @krzyzacy @k82cn