Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #84622: Create ILB firewall name with prefix "k8s-fw". #85245

Merged
merged 2 commits into from
Dec 6, 2019
Merged

Automated cherry pick of #84622: Create ILB firewall name with prefix "k8s-fw". #85245

merged 2 commits into from
Dec 6, 2019

Conversation

prameshj
Copy link
Contributor

@prameshj prameshj commented Nov 13, 2019 •
edited by tpepper

Cherry pick of #84622 on release-1.15.

#84622: Create ILB firewall name with prefix "k8s-fw".

For details on the cherry pick process, see the cherry pick requests page.

Release note:

Change GCP ILB firewall names to contain the "k8s-fw-" prefix like the rest of the firewall rules. This is needed for consistency and also for other components to identify the firewall rule as k8s/service-controller managed.

@prameshj
Create ILB firewall name with prefix "k8s-fw".
32aa93b 
ExternalLB and the healthcheck firewall rules follow this naming
convention.
addressed review comments.
@prameshj
Added new test, fixed existing tests.
dad36d2 
remove unused import
@prameshj prameshj force-pushed the automated-cherry-pick-of-#84622-upstream-release-1.15 branch from 77ab88b to dad36d2 Compare November 13, 2019 22:48
@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Nov 13, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 13, 2019
@k8s-ci-robot k8s-ci-robot added area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 13, 2019
@prameshj
Copy link
Contributor Author

/sig network
/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 13, 2019
@prameshj
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@prameshj
Copy link
Contributor Author

/assign @tpepper

@hoegaarden
Copy link
Contributor

@prameshj -- please see to get lgtm/approve on that PR, from the SIG (people) who lgtm'ed/approved the PR against master.

@prameshj
Copy link
Contributor Author

prameshj commented Dec 3, 2019

/assign @MrHohn @freehan

MrHohn
MrHohn approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, prameshj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2019
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 6, 2019
@k8s-ci-robot k8s-ci-robot removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 6, 2019
@tpepper
Copy link
Member

tpepper commented Dec 6, 2019

Since this was not an automated cherry pick, and the master branch PR had a meaningful release note, and the 1.16 branch peer CP had a release note, I've added the same here for the record.

@prameshj
Copy link
Contributor Author

prameshj commented Dec 6, 2019

Thanks @tpepper

@k8s-ci-robot k8s-ci-robot merged commit 388f59d into kubernetes:release-1.15 Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn MrHohn approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@freehan freehan

@tpepper tpepper

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.15
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@prameshj @hoegaarden @k8s-ci-robot @tpepper @MrHohn @freehan