Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the checking of robinIndex #85257

Merged
merged 1 commit into from Nov 15, 2019
Merged

Correct the checking of robinIndex #85257

merged 1 commit into from Nov 15, 2019

Conversation

tedyu
Copy link
Contributor

@tedyu tedyu commented Nov 14, 2019 •
edited

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR addresses the comment:
#85192 (comment)

Which issue(s) this PR fixes:
Fixes #

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 14, 2019
@tedyu
Copy link
Contributor Author

tedyu commented Nov 14, 2019

/cc @MikeSpreitzer

@tedyu tedyu mentioned this pull request Nov 14, 2019
Merged
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 14, 2019
@tedyu
Copy link
Contributor Author

tedyu commented Nov 14, 2019

/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 14, 2019
MikeSpreitzer
MikeSpreitzer approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@MikeSpreitzer MikeSpreitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2019
@MikeSpreitzer
Copy link
Member

This fixes a typo that came in with fresh code in #85192

@tedyu
Copy link
Contributor Author

tedyu commented Nov 14, 2019

/assign @lavalamp

@MikeSpreitzer MikeSpreitzer mentioned this pull request Nov 14, 2019
Merged
@MikeSpreitzer
Copy link
Member

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 14, 2019
@MikeSpreitzer
Copy link
Member

/remove-priority backlog

@k8s-ci-robot k8s-ci-robot removed the priority/backlog Higher priority than priority/awaiting-more-evidence. label Nov 14, 2019
@lavalamp
Copy link
Member

/lgtm
/approve

This should have created a bias for some queue. I think tests need to be improved.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, tedyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8dffc8d into kubernetes:master Nov 15, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeSpreitzer MikeSpreitzer MikeSpreitzer approved these changes

@ncdc ncdc Awaiting requested review from ncdc

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@lavalamp lavalamp

@MikeSpreitzer MikeSpreitzer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tedyu @MikeSpreitzer @lavalamp @k8s-ci-robot @yutedz