New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxier: improve node topology event handler logic #85345
proxier: improve node topology event handler logic #85345
Conversation
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
/sig network |
@andrewsykim: GitHub didn't allow me to assign the following users: imroc. Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Assign to me is not work, I wish I can have the power, I'm going to fire a issue to join the kubernetes org member. @m1093782566 have agreed to be my sponsor, can you agree to be my second sponsor ? @andrewsykim |
@imroc sure thing, ping me in the issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Review the full test history for this PR. Silence the bot with an |
Signed-off-by: Andrew Sy Kim kiman@vmware.com
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Improves logic of the node event handler for Service Topology by returning earlier if the node topology did not change.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: