New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plumb test state through to fake volume host creation for error handling #85426
Conversation
/assign @saad-ali |
8437400
to
999b79f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was a comical amount of plumbing.
999b79f
to
21f7060
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Post k8s v1.17 test cleanup - removing test panic and replacing it with lots of plumbing to do proper error handling for test errors.
/kind cleanup
/assign @misterikkit @msau42
/cc @liggitt
/sig storage
/priority backlog