Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apimachinery: Fix Dropped Test Error #85427

Merged
merged 4 commits into from Nov 23, 2019
Merged

apimachinery: Fix Dropped Test Error #85427

merged 4 commits into from Nov 23, 2019

Conversation

alrs
Copy link
Contributor

@alrs alrs commented Nov 18, 2019

This picks up three dropped test errors within apimachinery.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 18, 2019
@alrs
Copy link
Contributor Author

alrs commented Nov 18, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 18, 2019
@alrs
Copy link
Contributor Author

alrs commented Nov 18, 2019

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 18, 2019
@alrs
Copy link
Contributor Author

alrs commented Nov 18, 2019

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 18, 2019
@alrs
Copy link
Contributor Author

alrs commented Nov 18, 2019

/retest pull-kubernetes-verify

@alrs alrs force-pushed the fix-apimachinery-test-error branch from 20d9761 to d33336a Compare November 19, 2019 03:47
@alrs
Copy link
Contributor Author

alrs commented Nov 19, 2019

/test pull-kubernetes-verify
/test pull-kubernetes-e2e-gce

@alrs
Copy link
Contributor Author

alrs commented Nov 19, 2019

/test pull-kubernetes-verify

2 similar comments
@alrs
Copy link
Contributor Author

alrs commented Nov 19, 2019

/test pull-kubernetes-verify

@alrs
Copy link
Contributor Author

alrs commented Nov 19, 2019

/test pull-kubernetes-verify

@alrs alrs force-pushed the fix-apimachinery-test-error branch from d33336a to 32dec7f Compare November 20, 2019 18:07
@alrs
Copy link
Contributor Author

alrs commented Nov 20, 2019

/assign @liggitt

Thanks for the apimachinery talk at the Developer Summit, @liggitt.

@alrs alrs changed the title apimachinery: Fix Dropped Test Errors apimachinery: Fix Dropped Test Error Nov 20, 2019
@liggitt
Copy link
Member

liggitt commented Nov 23, 2019

please fix the verify error, then this lgtm

@alrs
Copy link
Contributor Author

alrs commented Nov 23, 2019

please fix the verify error, then this lgtm

All I see in prow is some type checker spew that occasionally syntax-highlights lines with the word panic in them, even though they don't represent Go panics. The words fail or error appear nowhere in the log.

What needs fixing?

@liggitt
Copy link
Member

liggitt commented Nov 23, 2019 

staticcheck
Some packages in hack/.staticcheck_failures are passing staticcheck. Please remove them.    
vendor/k8s.io/apimachinery/pkg/runtime/serializer

@alrs
Copy link
Contributor Author

alrs commented Nov 23, 2019

/assign @liggitt

@liggitt liggitt added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 23, 2019
@liggitt
Copy link
Member

liggitt commented Nov 23, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alrs, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2019
@liggitt
Copy link
Member

liggitt commented Nov 23, 2019

This doesn't need to be picked to 1.17

@alrs
Copy link
Contributor Author

alrs commented Nov 23, 2019

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit b1c39e9 into kubernetes:master Nov 23, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Nov 23, 2019
plsmaop pushed a commit to plsmaop/kubernetes that referenced this pull request Jan 19, 2020
@alrs @plsmaop
apimachinery: Fix Dropped Test Error (kubernetes#85427)
480dea2 
* apimachinery: fix dropped test error in pkg/util/net

* apimachinery: fix dropped test error in pkg/runtime/serializer

* apimachinery: fix dropped test error in pkg/conversion

* apimachinery: fix staticcheck warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alrs @liggitt @k8s-ci-robot