Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Removes [LinuxOnly] tag from a few tests #85453

Merged

Conversation

claudiubelu
Copy link
Contributor

What type of PR is this?

/kind cleanup

/sig testing
/sig windows
/area conformance

What this PR does / why we need it:

We've added the WindowsRunAsUserName feature some time ago, and it was promoted to Beta for v1.17. We can now remove the [LinuxOnly] tag for a few tests.

Which issue(s) this PR fixes:

Depends On: #83058
Depends On: #84882

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


We've added the WindowsRunAsUserName feature some time ago, and it was
promoted to Beta for v1.17. We can now remove the [LinuxOnly] tag for
a few tests.

Depends On: kubernetes#83058
Depends On: kubernetes#84882
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. area/conformance Issues or PRs related to kubernetes conformance tests needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test labels Nov 19, 2019
@claudiubelu
Copy link
Contributor Author

/test pull-kubernetes-integration

@PatrickLang PatrickLang added this to Backlog (v1.18) in SIG-Windows Dec 6, 2019
@PatrickLang PatrickLang moved this from Backlog (v1.18) to In Progress (v1.18) in SIG-Windows Dec 6, 2019
@dims
Copy link
Member

dims commented Dec 6, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2019
@claudiubelu
Copy link
Contributor Author

/assign @tallclair

@tallclair
Copy link
Member

/cc @PatrickLang
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: claudiubelu, dims, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 80f03eb into kubernetes:master Dec 17, 2019
SIG-Windows automation moved this from In Progress (v1.18) to Done (v1.18) Dec 17, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants