Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start-kubemark.sh fails with unbound variable #85507

Closed
notpad opened this issue Nov 21, 2019 · 1 comment · Fixed by #85508
Closed

start-kubemark.sh fails with unbound variable #85507

notpad opened this issue Nov 21, 2019 · 1 comment · Fixed by #85508
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@notpad
Copy link
Contributor

notpad commented Nov 21, 2019

What happened:
Run test/kubemark/start-kubemark.sh, will get error:

k8s.io/kubernetes/test/kubemark/gce/../../../cluster/kubemark/gce/config-default.sh: line 32: TEST_CLUSTER_LOG_LEVEL: unbound variable

Try to fix this by export TEST_CLUSTER_LOG_LEVEL=--v=4 and rerun get another error:

k8s.io/kubernetes/test/kubemark/gce/util.sh: line 45: KUBE_GCE_INSTANCE_PREFIX: unbound variable

Basically, we should have default value for TEST_CLUSTER_LOG_LEVEL and KUBE_GCE_INSTANCE_PREFIX. I found that they have default values before, and was deleted accidentally in #78246. Although we can predefine these two variables before running the script, it will be more convenient to have default values, and more friendly to people who are not familiar with this script.

What you expected to happen:
We should be able to run test/kubemark/start-kubemark.sh without setting any environment variable manually.

How to reproduce it (as minimally and precisely as possible):
test/kubemark/start-kubemark.sh

/cc @wojtek-t @mm4tt @mborsz
/sig testing
/sig cluster-lifecycle
/assign

@notpad notpad added the kind/bug Categorizes issue or PR as related to a bug. label Nov 21, 2019
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Nov 21, 2019
@notpad
Copy link
Contributor Author

notpad commented Nov 21, 2019

I have opened a PR to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants