Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in port-forward: named port not working with service #85511

Merged
merged 1 commit into from Dec 13, 2019
Merged

Fix a bug in port-forward: named port not working with service #85511

merged 1 commit into from Dec 13, 2019

Conversation

oke-py
Copy link
Contributor

@oke-py oke-py commented Nov 21, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:

kubectl port-forward to named Service port returns an error if Pod containerPort is also named port.
more details in kubernetes/kubectl#752

Which issue(s) this PR fixes:

Fixes kubernetes/kubectl#752

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix a bug in port-forward: named port not working with service

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 21, 2019
@oke-py
Copy link
Contributor Author

oke-py commented Nov 21, 2019

/assign @seans3

@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 21, 2019
@oke-py
Copy link
Contributor Author

oke-py commented Nov 21, 2019

/retest

@oke-py
Copy link
Contributor Author

oke-py commented Nov 22, 2019

@soltysh @mengqiy @seans3
All CI passed. I'd be happy if I get feedback from you. Thanks in advance.

@oke-py
Copy link
Contributor Author

oke-py commented Nov 29, 2019

The related issue is labeled as priority/P1. Is this PR priority/P1 too?

@pwittrock
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2019
@seans3
Copy link
Contributor

seans3 commented Dec 12, 2019

/priority P1

@k8s-ci-robot
Copy link
Contributor

@seans3: The label(s) priority/p1 cannot be applied, because the repository doesn't have them

In response to this:

/priority P1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@seans3
Copy link
Contributor

seans3 commented Dec 12, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 12, 2019
@seans3
Copy link
Contributor

seans3 commented Dec 12, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oke-py, pwittrock, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit 92a14f4 into kubernetes:master Dec 13, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 13, 2019
@oke-py oke-py deleted the port-forward-named-port branch December 13, 2019 01:21
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#85511 from oke-py/port-forward-named-port
c53c16a 
Fix a bug in port-forward: named port not working with service

Kubernetes-commit: 92a14f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seans3 seans3 seans3 approved these changes

@mengqiy mengqiy Awaiting requested review from mengqiy

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@seans3 seans3

@pwittrock pwittrock

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

port-forward: named port not working with service
4 participants
@oke-py @pwittrock @seans3 @k8s-ci-robot