New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HTTP readiness/liveness probes using NodePort #85611
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ksubrmnn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @feiskyer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment on why we are doing this?
/lgtm |
0200025
to
e87e4be
Compare
@dineshgovindasamy done. can you lgtm again? |
/lgtm |
What type of PR is this?
/kind bug
What this PR does / why we need it:
If the preserve-destination service annotation is present, we will disable routing mesh for NodePort.
This means that health services can use Node Port without falsely getting results from a different node.
Which issue(s) this PR fixes:
Fixes #86544
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: