New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove redundant definition of the defaultProvider in the scheduler #85695
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
This helper method seems unnecessary. Would you like to clean it up too? kubernetes/pkg/scheduler/scheduler.go Lines 803 to 806 in 9b75e36
Let me know when you are ready to merge. I will LGTM. |
can't take the address of a constant, so the function is necessary. |
/lgtm |
@ahg-g: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
"DefaultProvider" constant is defined in two places, this PR cleans that up.
Does this PR introduce a user-facing change?:
/cc @liu-cong