Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct invalid urls #85709

Merged
merged 1 commit into from Dec 6, 2019
Merged

correct invalid urls #85709

merged 1 commit into from Dec 6, 2019

Conversation

tanjunchen
Copy link
Member

What type of PR is this?

/kind documentation
/sig release cli
/kind cleanup
/priority backlog

What this PR does / why we need it:

Which issue(s) this PR fixes:

Ref:#85495

Special notes for your reviewer:

The Most urls from the table of [issue](#85495) have been fixed,
some of them are too old or need not to be corrected in my view.
Some original URL links have been archived, 
so they should be updated in the kk change log.

Does this PR introduce a user-facing change?:

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Contributor

@tanjunchen: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/cli Categorizes an issue or PR as relevant to SIG CLI. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. priority/backlog Higher priority than priority/awaiting-more-evidence. area/kubectl sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Nov 28, 2019
@tanjunchen
Copy link
Member Author

/release-note-none
/cc @liggitt Thanks your review.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 28, 2019
@tanjunchen
Copy link
Member Author

/cc @liggitt

@tanjunchen
Copy link
Member Author

/test pull-kubernetes-integration

liggitt
liggitt reviewed Nov 28, 2019
View reviewed changes
staging/src/k8s.io/kubectl/docs/book/pages/examples/kustomize.md Outdated
@@ -270,7 +270,7 @@ vars:
# specified by kustomize's configuration data.
#
# The default config data for vars is at
# https://github.com/kubernetes-sigs/kustomize/blob/master/pkg/transformers/config/defaultconfig/varreference.go
# https://github.com/kubernetes-sigs/kustomize/blob/master/api/konfig/builtinpluginconsts/varreference.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you point to a stable tag/branch?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kubernetes-sigs/kustomize/blob/v3.3.1/pkg/transformers/config/defaultconfig/varreference.go?Ok?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liggitt

liggitt
liggitt reviewed Nov 28, 2019
View reviewed changes
CHANGELOG-1.6.md Outdated
@@ -756,14 +756,14 @@ filename | sha256 hash

## Known Issues for v1.6.5

* If you use the [GLBC Ingress Controller](https://github.com/kubernetes/ingress/tree/master/controllers/gce),
* If you use the [GLBC Ingress Controller](https://github.com/kubernetes/ingress-nginx/tree/nginx-ingress-controller-0.9-beta.1/controllers/gce),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't expect nginx tags related to gce... cc @MrHohn or @bowei for what these should link to

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it would be https://github.com/kubernetes/ingress-nginx/tree/0.9.0-beta.1/controllers/gce instead (gce ingress controller used to live in the same repo).

Copy link
Member Author

@tanjunchen tanjunchen Dec 4, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrHohn Thanks
/cc @bowei

@justaugustus justaugustus added this to Review in progress in SIG Release Dec 2, 2019
@tanjunchen
Copy link
Member Author

/cc @liggitt any question?

liggitt
liggitt reviewed Dec 6, 2019
View reviewed changes
cluster/addons/fluentd-elasticsearch/README.md Outdated
@@ -72,7 +72,7 @@ avoid Fluentd pods scheduling there.
[xPack]: https://www.elastic.co/products/x-pack
[setupCreds]: https://www.elastic.co/guide/en/x-pack/current/setting-up-authentication.html#reset-built-in-user-passwords
[fluentdCreds]: https://github.com/uken/fluent-plugin-elasticsearch#user-password-path-scheme-ssl_verify
[fluentdEnvVar]: https://docs.fluentd.org/v0.12/articles/faq#how-can-i-use-environment-variables-to-configure-parameters-dynamically
[fluentdEnvVar]: https://docs.fluentd.org/v/0.12/articles
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a useful link for referring to fluentd envvars

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.fluentd.org/v0.12/articles/faq#how-can-i-use-environment-variables-to-configure-parameters-dynamically is gone!Maybe we need not to update it! i update the pr.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have any question?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the article is gone, just remove the link and reference

@tanjunchen
Copy link
Member Author

@liggitt done.Thanks

@tanjunchen
Copy link
Member Author

/test pull-kubernetes-bazel-test

@liggitt
Copy link
Member

liggitt commented Dec 6, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 117a3a7 into kubernetes:master Dec 6, 2019
SIG Release automation moved this from Review in progress to Done (1.18) Dec 6, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 6, 2019
@tanjunchen tanjunchen deleted the correct-404-ruls branch January 4, 2020 05:56
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#85709 from tanjunchen/correct-404-ruls
b909fcb 
correct  invalid  urls

Kubernetes-commit: 117a3a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@MrHohn MrHohn MrHohn left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tanjunchen @k8s-ci-robot @liggitt @MrHohn