Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: default etcd address based on the IP family #85745

Merged
merged 2 commits into from Dec 2, 2019
Merged

kubeadm: default etcd address based on the IP family #85745

merged 2 commits into from Dec 2, 2019

Conversation

aojea
Copy link
Member

@aojea aojea commented Nov 29, 2019 •
edited

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug

/kind cleanup

/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

kubeadm always configured the etcd endpoint to the IPv4 localhost address.

This patchs configures the right localhost address based on the used
AdvertiseAddress IP family.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kubeadm: uses the apiserver AdvertiseAddress IP family to choose the etcd endpoint IP family for non external etcd clusters

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 29, 2019
@aojea
Copy link
Member Author

aojea commented Nov 29, 2019

/hold
want to verify first is working correctly with ipv6
/test pull-kubernetes-e2e-kind-ipv6
/assign @neolit123 @fabriziopandini @ereslibre

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2019
@aojea
Copy link
Member Author

aojea commented Nov 29, 2019

/test pull-kubernetes-e2e-kind-ipv6

neolit123
neolit123 reviewed Nov 29, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @aojea
/approve
/assign @ereslibre

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 29, 2019
@aojea
Copy link
Member Author

aojea commented Nov 29, 2019

/test pull-kubernetes-e2e-kind-ipv6

@aojea
Copy link
Member Author

aojea commented Nov 29, 2019

/test pull-kubernetes-e2e-kind-ipv6

@aojea
Copy link
Member Author

aojea commented Nov 30, 2019

/test pull-kubernetes-conformance-kind-ipv6
/test pull-kubernetes-e2e-kind-ipv6

@aojea
Copy link
Member Author

aojea commented Nov 30, 2019

/test pull-kubernetes-conformance-kind-ipv6
flaky, only failed 3 tests, seems that now ipv6 is healthier

@aojea
Copy link
Member Author

aojea commented Nov 30, 2019

/test pull-kubernetes-e2e-gce
doesn't seems related to this PR

@aojea
Copy link
Member Author

aojea commented Nov 30, 2019 •
edited

/hold cancel
this is ready for review
It improves the e2e kind ipv6 tests, right now the kube-proxy and other daemon logs are less verbose with this change, one theory is that maybe having apiserver - etcd communicating in ipv4 and apiserver-kubelet in ipv6 was adding a penalty or a problem
/cc @BenTheElder

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2019
@aojea
Copy link
Member Author

aojea commented Nov 30, 2019

/test pull-kubernetes-conformance-kind-ipv6
/test pull-kubernetes-e2e-kind-ipv6

@aojea aojea mentioned this pull request Nov 30, 2019
Closed
@aojea
Copy link
Member Author

aojea commented Nov 30, 2019

/test pull-kubernetes-conformance-kind-ipv6
reported flaky test #85762

@aojea
Copy link
Member Author

aojea commented Nov 30, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@aojea
kubeadm: use correct IP family for etcd localhost
335a3e9 
kubeadm always use the IPv4 localhost address by defaultA for etcd

The probe hostname is obtained before the generation of the etcd
parameters, so it can't detect the right IP familiy for the
host of the probe.
This causes that with IPv6 clusters doesn't work because the probe
uses the IPv4 localhost address.

This patchs configures the right localhost address based on the used
AdvertiseAddress IP family.
@aojea
Copy link
Member Author

aojea commented Nov 30, 2019

/test pull-kubernetes-conformance-kind-ipv6
/test pull-kubernetes-e2e-kind-ipv6

ereslibre
ereslibre approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @aojea.

/lgtm
/hold
^ for more eyes to lgtm.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 2, 2019
@neolit123
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2019
@aojea
Copy link
Member Author

aojea commented Dec 2, 2019

/test pull-kubernetes-e2e-kind-ipv6

@k8s-ci-robot
Copy link
Contributor

@aojea: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kind-ipv6 335a3e9 link /test pull-kubernetes-e2e-kind-ipv6

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 3769de9 into kubernetes:master Dec 2, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 2, 2019
@aojea
Copy link
Member Author

aojea commented Dec 2, 2019

The ipv6 job is flaky and only two storage tests failed, is ok, thanks for the quick reviews

@aojea aojea deleted the kubeadm_etcd_ipv6 branch December 3, 2019 07:23
This was referenced Dec 18, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@ereslibre ereslibre ereslibre approved these changes

@detiber detiber Awaiting requested review from detiber

@kad kad Awaiting requested review from kad

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@ereslibre ereslibre

@neolit123 neolit123

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aojea @k8s-ci-robot @neolit123 @ereslibre @fabriziopandini