New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NetworkPolicy PolicyTypes validation #85747
Conversation
The validation had an excess nested loop and also caused wrong error feedback that all policyTypes input will be reported as unsupported if any of them is wrong.
Hi @tnqn. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tnqn
/ok-to-test
/lgtm |
/assign @thockin |
/lgtm |
@haosdent: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, thockin, tnqn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The validation had an excess nested loop and also caused wrong
error feedback that all policyTypes input will be reported as
unsupported if any of them is wrong.
What type of PR is this?
/kind bug
What this PR does / why we need it:
It removes an excess nested loop in
ValidateNetworkPolicySpec
, also fixes the incorrect validation result ofPolicyTypes
.Which issue(s) this PR fixes:
Fixes #85746
Special notes for your reviewer:
Current unit tests for networkpolicy validation only check whether there are validation errors but not check the errors content, so the fix doesn't introduce unit test change. I could make change to unit tests to further verify the content if it's desired.
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: