New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log error when writing checkpoint fails #85760
Conversation
/test pull-kubernetes-verify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I only see upsides to logging this additional information. Thanks for this change :)
/assign @jiayingz |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiayingz, tedyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/priority backlog |
What type of PR is this?
/kind bug
What this PR does / why we need it:
In ManagerImpl, there are two func's which call writeCheckpoint() but don't check return value.
This PR adds check of the return value and logs if there is error.
Which issue(s) this PR fixes:
Fixes #
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: