Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/e2e/auth: Fix static check failures #85780

Merged
merged 1 commit into from Dec 5, 2019
Merged

test/e2e/auth: Fix static check failures #85780

merged 1 commit into from Dec 5, 2019

Conversation

hwdef
Copy link
Member

@hwdef hwdef commented Dec 2, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind cleanup

What this PR does / why we need it:

Fix static check failures

Which issue(s) this PR fixes:

Ref: #81657

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 2, 2019
@hwdef
Copy link
Member Author

hwdef commented Dec 2, 2019

/assign @liggitt

@hwdef
Copy link
Member Author

hwdef commented Dec 2, 2019

/test pull-kubernetes-e2e-gce-100-performance

@liggitt
Copy link
Member

liggitt commented Dec 2, 2019

/assign @tallclair

@claudiubelu
Copy link
Contributor

/lgtm

only one minor change.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2019
liggitt
liggitt reviewed Dec 5, 2019
View reviewed changes
test/e2e/auth/audit_dynamic.go Outdated
@@ -107,7 +107,7 @@ var _ = SIGDescribe("[Feature:DynamicAudit]", func() {
})
framework.ExpectNoError(err, "failed to create proxy service")

config, err = framework.LoadConfig()
_, err = framework.LoadConfig()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we're not using the config, why are we loading it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry,I made a mistake, I fixed it.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2019
@liggitt
Copy link
Member

liggitt commented Dec 5, 2019

/priority backlog
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hwdef, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit fe80f32 into kubernetes:master Dec 5, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 5, 2019
@hwdef hwdef mentioned this pull request Dec 12, 2019
Merged
@hwdef hwdef deleted the fix-staticcheck16 branch January 16, 2020 09:52
@liggitt liggitt removed the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@eparis eparis Awaiting requested review from eparis

@sttts sttts Awaiting requested review from sttts

Assignees

@liggitt liggitt

@claudiubelu claudiubelu

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hwdef @liggitt @claudiubelu @k8s-ci-robot @fejta-bot @tallclair