Add more tests for the pod disruption budget endpoints #85819

nan-yu · 2019-12-02T19:32:46Z

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Add more coverage for the pod disruption budget e2e test

Special notes for your reviewer:
Last e2e test coverage report: #84740 (comment)

Endpoint	Tested	Update
patchPolicyV1beta1NamespacedPodDisruptionBudgetStatus	Untested	Tested
readPolicyV1beta1NamespacedPodDisruptionBudgetStatus	Untested	Tested
replacePolicyV1beta1NamespacedPodDisruptionBudgetStatus	Untested	Tested
listPolicyV1beta1PodDisruptionBudgetForAllNamespaces	Untested	Tested
deletePolicyV1beta1CollectionNamespacedPodDisruptionBudget	Untested	Tested
patchPolicyV1beta1NamespacedPodDisruptionBudget	Untested	Tested
listPolicyV1beta1NamespacedPodDisruptionBudget	Untested	Tested
replacePolicyV1beta1NamespacedPodDisruptionBudget	Tested	Tested
deletePolicyV1beta1NamespacedPodDisruptionBudget	Tested	Tested
createPolicyV1beta1NamespacedPodDisruptionBudget	Tested	Tested
readPolicyV1beta1NamespacedPodDisruptionBudget	Tested	Tested

Does this PR introduce a user-facing change?:

NONE

k8s-ci-robot · 2019-12-02T19:32:54Z

Welcome @nan-yu!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2019-12-02T19:32:55Z

Hi @nan-yu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nan-yu · 2019-12-02T19:33:54Z

cc @mortent

mortent · 2019-12-02T20:53:05Z

/ok-to-test

mortent · 2019-12-02T20:54:23Z

test/e2e/apps/disruption.go


 	appsv1 "k8s.io/api/apps/v1"
-	"k8s.io/api/core/v1"
+	v1 "k8s.io/api/core/v1"


corev1 is a better name here.

corev1 violates the import-aliases rule 😞

ERROR wrong alias for import "k8s.io/api/core/v1" should be v1 in file test/e2e/apps/disruption.go

mortent · 2019-12-02T21:09:02Z

test/e2e/apps/disruption.go

 	"github.com/onsi/ginkgo"
 	"github.com/onsi/gomega"
+	"k8s.io/apimachinery/pkg/types"


Move the two k8s imports to the next block.

RA489 · 2019-12-03T09:24:52Z

/release-note-none

RA489 · 2019-12-03T09:29:20Z

/release-note-none

nan-yu · 2020-02-01T00:54:53Z

[sig-storage] tests kept failing randomly 😞
/test pull-kubernetes-e2e-gce

nan-yu · 2020-02-03T17:16:24Z

/test pull-kubernetes-e2e-gce

nan-yu · 2020-02-03T18:25:33Z

[sig-storage] In-tree Volumes [Driver: local][LocalVolumeType: blockfs] [Testpattern: Pre-provisioned PV (default fs)] volumes should allow exec of files on the volume expand_more	1m46s
[sig-api-machinery] ResourceQuota should verify ResourceQuota with best effort scope. [Conformance] expand_more

[sig-storage] test failures again 😞

/test pull-kubernetes-e2e-gce

nan-yu · 2020-02-03T19:27:33Z

[sig-apps] DisruptionController evictions: maxUnavailable deny evictions, integer => should not allow an eviction expand_more	10m16s
[sig-storage] Downward API volume should provide podname as non-root with fsgroup [LinuxOnly] [NodeFeature:FSGroup] expand_more	1m0s
[sig-api-machinery] Garbage collector should delete RS created by deployment when not orphaning [Conformance] expand_more

/retest

nan-yu · 2020-02-03T21:16:01Z

[sig-storage] In-tree Volumes [Driver: local][LocalVolumeType: dir-bindmounted] [Testpattern: Pre-provisioned PV (default fs)] subPath should support readOnly directory specified in the volumeMount expand_more	1m54s
[sig-api-machinery] Garbage collector should not be blocked by dependency circle [Conformance] expand_more	2m4s
[sig-network] Network should set TCP CLOSE_WAIT timeout expand_more	1m3s
[sig-api-machinery] Garbage collector should delete RS created by deployment when not orphaning [Conformance] expand_mo

/retest

nan-yu · 2020-02-03T22:31:56Z

[sig-storage] In-tree Volumes [Driver: gcepd] [Testpattern: Dynamic PV (block volmode)] volumes should store data

/retest

nan-yu · 2020-02-04T00:12:09Z

[sig-storage] In-tree Volumes [Driver: local][LocalVolumeType: block] [Testpattern: Pre-provisioned PV (block volmode)] volumeMode should not mount / map unused volumes in a pod expand_more	52s
[sig-storage] PersistentVolumes-local [Volume type: blockfswithoutformat] One pod requesting one prebound PVC should be able to mount volume and write from pod1 expand_more	35s
[sig-storage] In-tree Volumes [Driver: local][LocalVolumeType: blockfs] [Testpattern: Pre-provisioned PV (default fs)] subPath should be able to unmount after the subpath directory is deleted expand_more	2m39s
[sig-storage] In-tree Volumes [Driver: hostPathSymlink] [Testpattern: Inline-volume (default fs)] subPath should support existing single file [LinuxOnly] expand_more	2m17s
[sig-storage] PersistentVolumes-local [Volume type: blockfswithoutformat] One pod requesting one prebound PVC should be able to mount volume and read from pod1 expand_more	41s
[sig-storage] In-tree Volumes [Driver: local][LocalVolumeType: dir-link-bindmounted] [Testpattern: Pre-provisioned PV (default fs)] subPath should support readOnly file specified in the volumeMount [LinuxOnly] expand_more	1m55s
[sig-storage] In-tree Volumes [Driver: local][LocalVolumeType: blockfs] [Testpattern: Pre-provisioned PV (default fs)] subPath should support non-existent path expand_more

/retest

nan-yu · 2020-02-04T01:22:28Z

PR rebased
@kow3ns , can you re-approve it? Thanks!

nan-yu · 2020-02-18T21:03:31Z

All commits squashed -> Ready to be re-reviewed and merged.

mortent · 2020-02-18T21:47:56Z

/lgtm

kow3ns · 2020-02-18T23:30:04Z

/approve

nan-yu · 2020-02-19T00:05:22Z

/assign @fabriziopandini

nan-yu · 2020-02-19T00:06:00Z

@fabriziopandini can you take a look at this PR and approve it? Thanks!

nan-yu · 2020-02-19T17:23:54Z

/assign @pohly
/assign @timothysc
/assign @andrewsykim

andrewsykim

/approve
/lgtm

For test/e2e/framework

k8s-ci-robot · 2020-02-19T19:52:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, kow3ns, nan-yu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~test/e2e/apps/OWNERS~~ [andrewsykim,kow3ns]
~~test/e2e/framework/OWNERS~~ [andrewsykim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nan-yu · 2020-02-19T23:53:42Z

2/13 Tests Failed
ClusterLoaderV2 expand_less 25m42s
error during /go/src/k8s.io/perf-tests/run-e2e.sh cluster-loader2 --nodes=100 --provider=gce --report-dir=/workspace/_artifacts --testconfig=testing/density/config.yaml --testconfig=testing/load/config.yaml --testconfig=testing/access-tokens/config.yaml --testoverrides=./testing/experiments/enable_prometheus_api_responsiveness.yaml --testoverrides=./testing/experiments/enable_restart_count_check.yaml --testoverrides=./testing/experiments/use_simple_latency_query.yaml --testoverrides=./testing/load/experimental/overrides/enable_configmaps.yaml --testoverrides=./testing/load/experimental/overrides/enable_daemonsets.yaml --testoverrides=./testing/load/experimental/overrides/enable_jobs.yaml --testoverrides=./testing/load/experimental/overrides/enable_pvs.yaml --testoverrides=./testing/load/experimental/overrides/enable_secrets.yaml --testoverrides=./testing/load/experimental/overrides/enable_statefulsets.yaml --testoverrides=./testing/load/gce/throughput_override.yaml (interrupted): signal: interrupt
Timeout expand_less 1h40m0s
kubetest --timeout triggered

/test pull-kubernetes-e2e-gce-100-performance

k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 2, 2019

k8s-ci-robot requested review from soltysh and timothysc December 2, 2019 19:35

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 2, 2019

nan-yu changed the title ~~Add more tests for the ../poddisruptionbudgets/{name} endpoint~~ Add more tests for the pod disruption budget endpoints Dec 2, 2019

mortent reviewed Dec 2, 2019

View reviewed changes

k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Dec 2, 2019

nan-yu force-pushed the pdb_e2etest branch from f8d6676 to b8b5a90 Compare December 2, 2019 23:21

nan-yu force-pushed the pdb_e2etest branch from b8b5a90 to 4f07fb3 Compare December 2, 2019 23:41

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 3, 2019

nan-yu force-pushed the pdb_e2etest branch 2 times, most recently from 2e9bbea to f2b5122 Compare February 18, 2020 19:03

Add more E2E tests for the ../poddisruptionbudgets endpoint

b757ca1

nan-yu force-pushed the pdb_e2etest branch from f2b5122 to b757ca1 Compare February 18, 2020 19:19

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2020

k8s-ci-robot assigned pohly Feb 19, 2020

andrewsykim reviewed Feb 19, 2020

View reviewed changes

k8s-ci-robot assigned andrewsykim Feb 19, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2020

nan-yu mentioned this pull request Feb 19, 2020

REQUEST: New membership for nan-yu kubernetes/org#1646

Closed

6 tasks

k8s-ci-robot merged commit 992aa00 into kubernetes:master Feb 20, 2020

k8s-ci-robot added this to the v1.18 milestone Feb 20, 2020

nan-yu deleted the pdb_e2etest branch February 20, 2020 00:16

liggitt moved this from GA blocking issues to Complete in PodDisruptionBudget Sep 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more tests for the pod disruption budget endpoints #85819

Add more tests for the pod disruption budget endpoints #85819

nan-yu commented Dec 2, 2019 •

edited

k8s-ci-robot commented Dec 2, 2019

k8s-ci-robot commented Dec 2, 2019

nan-yu commented Dec 2, 2019

mortent commented Dec 2, 2019

mortent Dec 2, 2019

nan-yu Dec 2, 2019

mortent Dec 2, 2019

RA489 commented Dec 3, 2019

RA489 commented Dec 3, 2019

nan-yu commented Feb 1, 2020

nan-yu commented Feb 3, 2020

nan-yu commented Feb 3, 2020

nan-yu commented Feb 3, 2020

nan-yu commented Feb 3, 2020

nan-yu commented Feb 3, 2020

nan-yu commented Feb 4, 2020

nan-yu commented Feb 4, 2020

nan-yu commented Feb 18, 2020

mortent commented Feb 18, 2020

kow3ns commented Feb 18, 2020

nan-yu commented Feb 19, 2020

nan-yu commented Feb 19, 2020

nan-yu commented Feb 19, 2020 •

edited

andrewsykim left a comment

k8s-ci-robot commented Feb 19, 2020

nan-yu commented Feb 19, 2020

Add more tests for the pod disruption budget endpoints #85819

Add more tests for the pod disruption budget endpoints #85819

Conversation

nan-yu commented Dec 2, 2019 • edited

k8s-ci-robot commented Dec 2, 2019

k8s-ci-robot commented Dec 2, 2019

nan-yu commented Dec 2, 2019

mortent commented Dec 2, 2019

mortent Dec 2, 2019

Choose a reason for hiding this comment

nan-yu Dec 2, 2019

Choose a reason for hiding this comment

mortent Dec 2, 2019

Choose a reason for hiding this comment

RA489 commented Dec 3, 2019

RA489 commented Dec 3, 2019

nan-yu commented Feb 1, 2020

nan-yu commented Feb 3, 2020

nan-yu commented Feb 3, 2020

nan-yu commented Feb 3, 2020

nan-yu commented Feb 3, 2020

nan-yu commented Feb 3, 2020

nan-yu commented Feb 4, 2020

nan-yu commented Feb 4, 2020

nan-yu commented Feb 18, 2020

mortent commented Feb 18, 2020

kow3ns commented Feb 18, 2020

nan-yu commented Feb 19, 2020

nan-yu commented Feb 19, 2020

nan-yu commented Feb 19, 2020 • edited

andrewsykim left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Feb 19, 2020

nan-yu commented Feb 19, 2020

nan-yu commented Dec 2, 2019 •

edited

nan-yu commented Feb 19, 2020 •

edited