Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GCS bucket for crictl on windows. #85825

Merged
merged 1 commit into from Dec 3, 2019
Merged

Use GCS bucket for crictl on windows. #85825

merged 1 commit into from Dec 3, 2019

Conversation

Random-Liu
Copy link
Member

Use GCS bucket to install crictl on windows.

Signed-off-by: Lantao Liu lantaol@google.com

none

@Random-Liu
Use GCS bucket for crictl on windows.
e687bf4 
Signed-off-by: Lantao Liu <lantaol@google.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 2, 2019
@Random-Liu Random-Liu added area/platform/gce area/provider/gcp Issues or PRs related to gcp provider kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/windows Categorizes an issue or PR as relevant to SIG Windows. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 2, 2019
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Dec 2, 2019
@Random-Liu
Copy link
Member Author

/test pull-kubernetes-e2e-windows-gce

@k8s-ci-robot
Copy link
Contributor

@Random-Liu: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-windows-gce e687bf4 link /test pull-kubernetes-e2e-windows-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pjh
Copy link
Contributor

pjh commented Dec 3, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pjh, Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2019
@yliaog
Copy link
Contributor

yliaog commented Dec 3, 2019

/skip

@yliaog
Copy link
Contributor

yliaog commented Dec 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 61a709d into kubernetes:master Dec 3, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 3, 2019
@PatrickLang PatrickLang added this to Done (v1.18) in SIG-Windows Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtaufen mtaufen Awaiting requested review from mtaufen

@pjh pjh Awaiting requested review from pjh

Assignees

@pjh pjh

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/platform/gce area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Random-Liu @k8s-ci-robot @pjh @yliaog