Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize some log config #85838

Merged
merged 4 commits into from Dec 10, 2019
Merged

optimize some log config #85838

merged 4 commits into from Dec 10, 2019

Conversation

like-inspur
Copy link
Contributor

/kind bug
I commit some changes about log and monitor, now monitor has been removed from kubernetes, but log config is saved, So I commit some bug for log config like elasticsearch and fluentd #85195

@k8s-ci-robot
Copy link
Contributor

@like-inspur: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 3, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @like-inspur. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 3, 2019
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 3, 2019
@fejta-bot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 3, 2019
coffeepac
coffeepac reviewed Dec 5, 2019
View reviewed changes
cluster/addons/fluentd-elasticsearch/fluentd-es-configmap.yaml Outdated
@@ -473,7 +473,7 @@ data:
retry_forever
retry_max_interval 30
chunk_limit_size 2M
queue_limit_length 8
total_limit_size 2G
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems quite large for a default install. I wouldn't want this to go past 500MB.

How did you arrive at this setting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK，then set total_limit_size 500M can achieve this goal

@coffeepac
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 6, 2019
@coffeepac
Copy link
Contributor

@like-inspur can you remove the changes to the prometheus files? as you noted, they no longer exist.

also, please increase the patch version for all yaml files so that people can explicitly opt into these features

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2019
@like-inspur @binflying
es add readiness and liveness health check
3258485 
use transport as health check port
@like-inspur @binflying
fluentd add port promtheus and health check
a192b59 
fluentd readiness and liveness health check can use fluent-plugin-prometheus port
@like-inspur @binflying
update fluentd-es-configmap
3ffd8f3 
queue_limit_length is not supported by fluentd, and I config total_limit_size 2G for buffer total size
@like-inspur @binflying
update total_limit_size
597816c
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 9, 2019
@like-inspur
Copy link
Contributor Author

@coffeepac hello，I have remove the changes to the prometheus file

@coffeepac
Copy link
Contributor

/approve
/lgtm
/release-note-none

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 10, 2019
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coffeepac, like-inspur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7a9788b into kubernetes:master Dec 10, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 10, 2019
@monotek
Copy link
Member

monotek commented Dec 18, 2019

Just saw this change now.

Total limit size 500 means to lower the default value which is 512MB.

Regarding to the documentation (https://docs.fluentd.org/configuration/buffer-section) the removed option is for 0.12 compatibility and should not do any harm.

Whats the error you've seen?

@monotek
Copy link
Member

monotek commented Mar 3, 2020

Besides having same liveness and readiness probes ist bad practice.

See: https://srcco.de/posts/kubernetes-liveness-probes-are-dangerous.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coffeepac coffeepac coffeepac left review comments

@zmerlynn zmerlynn Awaiting requested review from zmerlynn

Assignees

@coffeepac coffeepac

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@like-inspur @k8s-ci-robot @fejta-bot @coffeepac @monotek