Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix golint check in test/e2e_node/runner/remote #85890

Merged
merged 1 commit into from Dec 5, 2019
Merged

fix golint check in test/e2e_node/runner/remote #85890

merged 1 commit into from Dec 5, 2019

Conversation

tanjunchen
Copy link
Member

@tanjunchen tanjunchen commented Dec 4, 2019 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fix golint issues in test/e2e_node/runner/remote

Which issue(s) this PR fixes:

Ref #68026

Special notes for your reviewer:

/cc @oomichi

Does this PR introduce a user-facing change?:

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

test/e2e_node/runner/remote/run_remote.go:108:6: exported type Archive should have comment or be unexported
test/e2e_node/runner/remote/run_remote.go:114:6: exported type TestResult should have comment or be unexported
test/e2e_node/runner/remote/run_remote.go:133:1: comment on exported type ImageConfig should be of the form "ImageConfig ..." (with optional leading article)
test/e2e_node/runner/remote/run_remote.go:139:6: exported type Accelerator should have comment or be unexported
test/e2e_node/runner/remote/run_remote.go:144:6: exported type Resources should have comment or be unexported
test/e2e_node/runner/remote/run_remote.go:148:6: exported type GCEImage should have comment or be unexported
test/e2e_node/runner/remote/run_remote.go:431:20: error strings should not be capitalized or end with punctuation or a newline
test/e2e_node/runner/remote/run_remote.go:438:2: var externalIp should be externalIP
test/e2e_node/runner/remote/run_remote.go:447:20: error strings should not be capitalized or end with punctuation or a newline
test/e2e_node/runner/remote/run_remote.go:646:21: error strings should not be capitalized or end with punctuation or a newline
test/e2e_node/runner/remote/run_remote.go:649:3: var externalIp should be externalIP
test/e2e_node/runner/remote/run_remote.go:702:6: func getExternalIp should be getExternalIP

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 4, 2019
@tanjunchen
Copy link
Member Author

/assign @fejta

@tanjunchen
Copy link
Member Author

/release-note-none

fejta
fejta reviewed Dec 5, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2f58d2e into kubernetes:master Dec 5, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 5, 2019
@tanjunchen tanjunchen deleted the fix-golint-test-e2e_node-ruuner branch January 4, 2020 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta left review comments

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@fejta fejta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tanjunchen @k8s-ci-robot @fejta